This fixes a bug where the history was cleared when the font size was changed. The history is now kept unless explicitly cleared with the clear button.
Fix history deletion bug after font size change #7668
pull achow101 wants to merge 1 commits into bitcoin:master from achow101:rpcconsole-hist-fix changing 2 files +8 −5-
achow101 commented at 4:59 PM on March 11, 2016: member
-
21e45a097e
Fix history deletion bug after font change
The history is no longer cleared after the font size is changed
- achow101 force-pushed on Mar 11, 2016
-
paveljanik commented at 6:50 PM on March 11, 2016: contributor
3 changed lines, 3 new lines added (could be two if if's opening
{is on the same line ;-).Nice and elegant!
Tested ACK. History is not deleted after font size changed in the UI.
-
jonasschnelli commented at 7:02 PM on March 11, 2016: contributor
Hmm... when I had implemented this, I encountered that the font size change only works after clearing the console (because of some html subsystem). The console content should be restored at L494.
Are you sure the console window gets cleared when changing the font size? If so, what platform?
-
achow101 commented at 7:05 PM on March 11, 2016: member
@jonasschnelli It isn't the console, but rather the history in the text box for commands. When you hit the up arrow you can choose a previously entered command but after changing the font size that history is cleared. This fixes that
-
jonasschnelli commented at 7:08 PM on March 11, 2016: contributor
Ah! Right. Nice catch!
utACK.
- jonasschnelli added the label GUI on Mar 11, 2016
-
jonasschnelli commented at 8:24 AM on March 14, 2016: contributor
Tested ACK 21e45a097e154be6be4a503f2181896c5f761385
- jonasschnelli merged this on Mar 14, 2016
- jonasschnelli closed this on Mar 14, 2016
- jonasschnelli referenced this in commit b24266c207 on Mar 14, 2016
- achow101 deleted the branch on Oct 29, 2016
- cddjr referenced this in commit 0b58394fc0 on Apr 5, 2017
- cddjr referenced this in commit ce87d6be0b on Apr 6, 2017
- codablock referenced this in commit 1330e642d6 on Sep 5, 2017
- codablock referenced this in commit b967ad09ed on Sep 5, 2017
- UdjinM6 referenced this in commit 690cb58f80 on Sep 7, 2017
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels