When miniupnpc isn't installed, building fails due to wrong check in makefile.unix.
fix check for USE_UPNP in makefile.unix #364
pull floe wants to merge 1 commits into bitcoin:master from floe:master changing 1 files +1 −1-
floe commented at 4:44 PM on June 29, 2011: none
-
fix check for USE_UPNP in makefile.unix ad9b600886
-
gavinandresen commented at 5:00 PM on June 29, 2011: contributor
Talk to BlueMatt about this. I think it is supposed to be the way it is.
-
TheBlueMatt commented at 6:38 PM on June 29, 2011: member
As is documented in doc/build-unix.txt:
Requires miniupnpc for UPnP port mapping. It can be downloaded from http://miniupnp.tuxfamily.org/files/. UPnP support is compiled in and turned off by default. Set USE_UPNP to a different value to control this: USE_UPNP= no UPnP support, miniupnp not required; USE_UPNP=0 (the default) UPnP support turned off by default at runtime; USE_UPNP=1 UPnP support turned on by default at runtime.
-
floe commented at 6:49 PM on June 29, 2011: none
Not quite correct: the original check in makefile.Unix:
ifdef USE_UPNP
is always true, even if USE_UPNP is zero. I doubt that was the original intention, hence the patch.
Florian
TheBlueMatt reply@reply.github.com schrieb:
As is documented in doc/build-unix.txt:
Requires miniupnpc for UPnP port mapping. It can be downloaded from http://miniupnp.tuxfamily.org/files/. UPnP support is compiled in and turned off by default. Set USE_UPNP to a different value to control this: USE_UPNP= no UPnP support, miniupnp not required; USE_UPNP=0 (the default) UPnP support turned off by default at runtime; USE_UPNP=1 UPnP support turned on by default at runtime.
Reply to this email directly or view it on GitHub: #364 (comment)
Sent from some flat thingy without a proper keyboard.
-
TheBlueMatt commented at 6:52 PM on June 29, 2011: member
No, that is the intention, but USE_UPNP is not always defined. If you build using make -f makefile.unix USE_UPNP= ie nothing after the =, it will undefine USE_UPNP and you are fine. Please look through old bugs and two or three identical pull requests to this one.
-
floe commented at 6:53 PM on June 29, 2011: none
Argh, I just got it. Sorry for the noise.
Florian
TheBlueMatt reply@reply.github.com schrieb:
As is documented in doc/build-unix.txt:
Requires miniupnpc for UPnP port mapping. It can be downloaded from http://miniupnp.tuxfamily.org/files/. UPnP support is compiled in and turned off by default. Set USE_UPNP to a different value to control this: USE_UPNP= no UPnP support, miniupnp not required; USE_UPNP=0 (the default) UPnP support turned off by default at runtime; USE_UPNP=1 UPnP support turned on by default at runtime.
Reply to this email directly or view it on GitHub: #364 (comment)
Sent from some flat thingy without a proper keyboard.
- tcatm closed this on Jun 29, 2011
- zathras-crypto referenced this in commit eb4ab7a5f6 on May 3, 2016
- laanwj referenced this in commit 0ffb3bd95f on Aug 4, 2016
- laanwj referenced this in commit b2135359b3 on Aug 16, 2016
- MarcoFalke referenced this in commit 64dfdde0aa on Dec 13, 2016
- deadalnix referenced this in commit e4570184ff on Jan 19, 2017
- ptschip referenced this in commit 2a8e233180 on Apr 5, 2017
- lateminer referenced this in commit 638668132c on Oct 16, 2019
- cryptapus referenced this in commit e9b2891a8c on May 3, 2021
- rajarshimaitra referenced this in commit f6a63e3c90 on Aug 5, 2021
- DrahtBot locked this on Sep 8, 2021
