Doc: Update isStandardTx comment #7786

Incremental improvement to readability.

utACK 8d3a32fcd3fe4747c64bd09e344c0a22751784d8

This could use a more descriptive commit message. (see #7785 for an example on how to do this)

@s-matthew-english Can you please fix these nits, so we an proceed with this PR?

done.

On Wed, Apr 6, 2016 at 10:08 AM, paveljanik notifications@github.com wrote:

@s-matthew-english https://github.com/s-matthew-english Can you please fix these nits, so we an proceed with this PR?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub #7786 (comment)

Please squash and make the commit message something like [doc] Improve IsStandardTx comment

I'm new to contributing to projects on here, but I'm trying to learn, that's why I did this, so I'm wondering, what does it mean to squash the commit? How to do that?

*Please forgive me if this question is daft.

See e.g. #1952 where git rebase -i is described. Or you are doing it via web (patch-2)?

But squashing these two commits into one can be done when merging, but better do this yourself.

cool- I'll do this tonight

On Thu, Apr 7, 2016 at 7:42 PM, paveljanik notifications@github.com wrote:

But squashing these two commits into one can be done when merging, but better do this yourself.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub #7786 (comment)

so I tried to do it from my terminal- since originally I made these changes just online using GitHub web app- but- did the changes percolate? I used the suggested name of the commit message and all :/

Please forgive me if this is a bit daft- but- Im just learning how to become a contributor to an open source project.

Looks like you need to git push yet :-)

so then just 'git push -u origin master'?

On Fri, Apr 8, 2016 at 9:33 PM, paveljanik notifications@github.com wrote:

Looks like you need to git push yet :-)

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub #7786 (comment)

I think git push -f origin patch-2

he tell me this:

"error: src refspec patch-2 does not match any."

On Fri, Apr 8, 2016 at 9:38 PM, paveljanik notifications@github.com wrote:

I think git push -f origin patch-2

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub #7786 (comment)

Hmm, your current work is in patch-2, so it looks like to do not have a proper clone of it locally. What does git remote show origin show for you? Can you join IRC?

Ah, so you cloned the original source, not your patch-2 branch. OK. This should work then:

git remote add s-matthew-english https://www.github.com/s-matthew-english/bitcoin
git push -f s-matthew-english patch-2

ah, rats! seems- no dice!

http://stackoverflow.com/questions/5802426/git-error-src-refspec-master-does-not-match-any

^ I tried that :/ anyway- I'll keep werking on it

So please start from scratch in empty directory:

git clone https://www.github.com/s-matthew-english/bitcoin
cd bitcoin
git checkout --track origin/patch-2
git rebase -i e9723cb27384ccd8e4bd78d2fea907534fd0d94a
... change pick to squash on the second line
... change the commit message
git push -f origin patch-2

OK?

Hmm- I don't know if it worked.

I'm not so good at VIM

I tried to change the commit message after the step git rebase -i e9723cb27384ccd8e4bd78d2fea907534fd0d94a

but I don't know if these ones percolated: ... change pick to squash on the second line ... change the commit message

and then finally it just told me:

"Everything up-to-date"

So- that doesn't seem right :/

I'm sorry to be so daft believe me!

How to join IRC?

Join IRC here: https://bitcoincore.org/en/contribute/ - there is a webchat link to join irc.freenode.net.

for some reason the link http://irc.freenode.net/ seems not to load on Chromium or Firefox

On Fri, Apr 8, 2016 at 10:35 PM, paveljanik notifications@github.com wrote:

Join IRC here: https://bitcoincore.org/en/contribute/ - there is a webchat link to join irc.freenode.net.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub #7786 (comment)

maybe my Uni blocks it?

On Fri, Apr 8, 2016 at 10:45 PM, Matthew English < s.matthew.english@gmail.com> wrote:

for some reason the link http://irc.freenode.net/ seems not to load on Chromium or Firefox

On Fri, Apr 8, 2016 at 10:35 PM, paveljanik notifications@github.com wrote:

Join IRC here: https://bitcoincore.org/en/contribute/ - there is a webchat link to join irc.freenode.net.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub #7786 (comment)

Click on #bitcoin-core-dev.

ok cool- I'm there as 'matthew_english'

ACK https://github.com/bitcoin/bitcoin/pull/7786/commits/03c77fdc143fb8d533011f23164daac560e381b2

@s-matthew-english Thanks for going through this @paveljanik Thanks for helping him go through this

ACK https://github.com/bitcoin/bitcoin/pull/7786/commits/03c77fdc143fb8d533011f23164daac560e381b2