RPC: do not print minping time in getpeerinfo when no ping received yet #7842

pull paveljanik wants to merge 1 commits into bitcoin:master from paveljanik:20160408_getpeerinfo_no_ping_yet changing 1 files +7 −5

paveljanik commented at 4:58 PM on April 8, 2016: contributor

When no ping received yet, minping value in getpeerinfo is uninitialized (resp. initialized to std::numeric_limits<int64_t>::max()/1e6). Do not print it in such cases.

Document such behaviour (also for pingwait).

Fixes #7837.
MarcoFalke commented at 5:03 PM on April 8, 2016: member

utACK
laanwj commented at 7:30 AM on April 9, 2016: member

Just realized: dPingTime suffers from the same problem if there has never been a ping. It gets initialized to zero, but that's just as well a nonsensical value if we really want to be consistent at 'leave out fields that have no value'.
laanwj added the label RPC/REST/ZMQ on Apr 9, 2016
laanwj commented at 7:36 AM on April 9, 2016: member

utACK ~~https://github.com/bitcoin/bitcoin/pull/7842/commits/e8d630d109e6529799e9c3c7fb34516abbf0b2fb~~ https://github.com/bitcoin/bitcoin/pull/7842/commits/62a64860580253d9c733f3b8826908bba40eab1d
paveljanik commented at 7:38 AM on April 9, 2016: contributor

Do you want me to change it in one go?
laanwj commented at 7:42 AM on April 9, 2016: member

Do you want me to change it in one go?

I'd say it makes sense, it's basically the same thing.
RPC: do not print ping info in getpeerinfo when no ping received yet, fix help 62a6486058
paveljanik force-pushed on Apr 9, 2016
paveljanik commented at 7:52 AM on April 9, 2016: contributor

Force pushed.
laanwj commented at 8:16 AM on April 9, 2016: member

Great!
MarcoFalke commented at 10:28 AM on April 9, 2016: member

utACK 62a6486
sipa commented at 1:57 PM on April 12, 2016: member

Concept ACK

laanwj commented at 2:08 PM on April 14, 2016: member

Tested ACK. New connection has neither minping, pingtime or pingwait.

[
  {
    "id": 1,
    "addr": "127.0.0.1:56078",
    "services": "0000000000000000",
    "relaytxes": false,
    "lastsend": 0,
    "lastrecv": 0,
    "bytessent": 0,
    "bytesrecv": 0,
    "conntime": 1460642850,
    "timeoffset": 0,
    "version": 0,
    "subver": "",
    "inbound": true,
    "startingheight": -1,
    "banscore": 0,
    "synced_headers": -1,
    "synced_blocks": -1,
    "inflight": [
    ],
    "whitelisted": false,
    "bytessent_per_msg": {
    },
    "bytesrecv_per_msg": {
    }
  }
]

laanwj merged this on Apr 14, 2016
laanwj closed this on Apr 14, 2016
laanwj referenced this in commit d97101e5a8 on Apr 14, 2016
gmaxwell commented at 3:55 PM on April 14, 2016: contributor

posthumous "hey, I was whining about that" ACK.
codablock referenced this in commit 3be6690b50 on Sep 7, 2017
UdjinM6 referenced this in commit 9707ca5cea on Sep 9, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#7837 `getpeerinfo` should report minping differently if there never was a ping