The actual release process had quite diverged from what was written here, also clarify things a bit and update the style to be like our other .md files. More like "rewrite the entire thing".
Best to read the rendered version: https://github.com/laanwj/bitcoin/blob/2016_04_update_release_process/doc/release-process.md
Closes #7595 as well by removing the hardcoded version number from verify.sh.
235 | ```bash 236 | sha256sum * > SHA256SUMS 237 | +``` 238 | + 239 | +The list of files should be: 240 | +```
Should we use {VERSION} here in place of hard coded numbers
Sure!
Concept ACK. Confirmed changes to verify.sh are working
188 | + popd 189 | 190 | -Commit your signature for the signed OS X/Windows binaries: 191 | +Wait for Windows/OS X detached signatures: 192 | + 193 | + Once the Windows/OS X builds each have 3 matching signatures, they will be signed with their respective release keys.
You can't add a new line here and keep the pre-whitespace. This will mess with the formatting
This should probably be a - list
181 | - popd 182 | + pushd gitian.sigs 183 | + git add ${VERSION}-linux/${SIGNER} 184 | + git add ${VERSION}-win-unsigned/${SIGNER} 185 | + git add ${VERSION}-osx-unsigned/${SIGNER} 186 | + git commit -a
I always end up doing something like git commit -a -S -m "${SIGNER}'s unsigned gitian build for ${VERSION}"
The extra -S is probably unnecessary because we end signing a commit containing signed files, but I don't think it should hurt anything and GPG already has to be set up correctly for gsign to work.
You'd need to git config ... for git commit -S to work
There's not really a need to sign commits with signatures in them, I think that'll just result in confusion which signatures are used.
137 | 138 | - ./bin/gverify -v -d ../gitian.sigs/ -r ${VERSION}-linux ../bitcoin/contrib/gitian-descriptors/gitian-linux.yml 139 | - ./bin/gverify -v -d ../gitian.sigs/ -r ${VERSION}-win-unsigned ../bitcoin/contrib/gitian-descriptors/gitian-win.yml 140 | - ./bin/gverify -v -d ../gitian.sigs/ -r ${VERSION}-osx-unsigned ../bitcoin/contrib/gitian-descriptors/gitian-osx.yml 141 | - 142 | - popd
Are you sure this is no longer required here?
The verifies? They're still there, this is just a formatting change
No, the popd
Well if there should be a popd it should at least be balanced by a pushd. Out of the blue it is very strange.
You have moved it up instead. See my other comment above ;)
I think they were "balanced" before. (Not necessarily in each section, though)
Hah, okay, having pushd/popd open over sections is weird, I must have not been the only one to never get that point. I'll add a pushd and popd around this.
108 | +Ensure gitian-builder is up-to-date to take advantage of new caching features (`e9741525c` or later is recommended). 109 | 110 | -###Fetch and create inputs: (first time, or when dependency versions change) 111 | + pushd ./gitian-builder 112 | + git pull 113 | + popd
If you add this, you'd need to add pushd ./gitian-builder at the other places?
Yes using pushd/popd consistently everywhere would make sense.
utACK cdb7804
utACK cdb7804
The actual release process quite diverged from what was written here,
also clarify things a bit.
Closes #7595 as by removing the hardcoded version number from
`verify.sh`.
squashed 2873dbd 3707e43 373bfef 6e25333 cdb7804 into c907f4d 182bec4 f154470 .