bitcoin-util-test.py fails with python3.2 #7893

issue MarcoFalke opened this issue on April 16, 2016
  1. MarcoFalke commented at 2:57 PM on April 16, 2016: member

    Steps to reproduce:

    $ cd src/
    $ srcdir=. PYTHONPATH=`pwd`/test python3.2 `pwd`/test/bitcoin-util-test.py
    
    Traceback (most recent call last):
      File "/home/marco/bitcoin/src/test/bitcoin-util-test.py", line 12, in <module>
        "bitcoin-util-test.json",buildenv)
      File "/home/marco/bitcoin/src/test/bctest.py", line 51, in bctester
        bctest(testDir, testObj, buildenv.exeext)
      File "/home/marco/bitcoin/src/test/bctest.py", line 29, in bctest
        outs = proc.communicate(input=inputData)
      File "/usr/lib/python3.2/subprocess.py", line 819, in communicate
        return self._communicate(input)
      File "/usr/lib/python3.2/subprocess.py", line 1425, in _communicate
        stdout, stderr = self._communicate_with_poll(input)
      File "/usr/lib/python3.2/subprocess.py", line 1492, in _communicate_with_poll
        input_offset += os.write(fd, chunk)
    TypeError: 'str' does not support the buffer interface
    

    This works with python3.4 and python2.7 as described in #7878#issue-148438568. This also should work with python 3.2, but maybe I am missing something obvious...

  2. jonasschnelli added the label Tests on Apr 17, 2016
  3. laanwj commented at 11:17 AM on April 17, 2016: member

    Yes, Python 3 went through some trouble in their initial releases. We should set a minimum version of Python 3 that we support. What versions of distributions ship with Python 3.2? Ubuntu LTS (14.04) uses 3.4.3 at least.

  4. MarcoFalke commented at 12:09 PM on April 17, 2016: member

    What versions of distributions ship with Python 3.2? Ubuntu LTS (14.04) uses 3.4.3 at least.

    Ubuntu 12.04 which we still use in travis

    http://packages.ubuntu.com/precise/python/python3

  5. laanwj commented at 10:43 AM on April 28, 2016: member

    Closing this, travis has switched to Trusty so Python 3.2 is none of our concern.

  6. laanwj closed this on Apr 28, 2016

  7. Oniksikyn referenced this in commit 7ec760a7c9 on Feb 24, 2018
  8. MassMason referenced this in commit 8a6962158c on Sep 14, 2018
  9. MassMason referenced this in commit 50ddb4bf35 on Sep 14, 2018
  10. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me