Fix help text around importaddress and rename it to importscript #7903

pull TheBlueMatt wants to merge 1 commits into bitcoin:master from TheBlueMatt:16-04-importaddress-helptext changing 3 files +7 −4

TheBlueMatt commented at 4:52 AM on April 18, 2016: member

importaddress' help text was changed to talk primarily about importing raw scripts instead of addresses but the help text missed one replacement. It also makes much more sense for it to be renamed importscript, so both are now aliases for importscript.
rustyrussell commented at 4:54 AM on April 18, 2016: contributor

utAck: thanks Matt!
btcdrak commented at 4:57 AM on April 18, 2016: contributor

utACK

Fix help text around importaddress and rename it to importscript

importaddress' help text was changed to talk primarily about
importing raw scripts instead of addresses but the help text missed
one replacement. It also makes much more sense for it to be renamed
importscript, so both are now aliases for importscript.

543394a985

TheBlueMatt force-pushed on Apr 18, 2016
jonasschnelli added the label RPC/REST/ZMQ on Apr 18, 2016
sipa commented at 9:31 AM on April 18, 2016: member

Please see #7687 and #7551 (comment)

I would really prefer that importscript was a separate RPC implementation without all the magic effects of matching with addresses.
laanwj commented at 8:50 AM on April 25, 2016: member

I agree with @sipa. If you add a new method, make use of that opportunity to add a saner interface.
TheBlueMatt commented at 8:42 PM on May 18, 2016: member

I actually think the interface is (mostly) sane...indeed, adding a non-P2SH address is strangely handled, indeed. But the fact that imported addresses are treated as change (#7687) is a separate bug. You still need to be able to hand it a script and have it generate the P2SH address (optionally, sometimes you dont want this). importscript should probably be pretty much what it is here, IMO.
sipa commented at 12:01 PM on August 25, 2016: member

I still believe that importscript should not copy all the magic behaviour of importaddress.
TheBlueMatt commented at 9:41 PM on October 23, 2016: member

Closing in favor of other solutions.
TheBlueMatt closed this on Oct 23, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels