[RPC] push back getaddednodeinfo dead value #7926

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:getaddedpushbackmaster changing 1 files +1 −0

instagibbs commented at 6:22 PM on April 22, 2016: member

I believe this is the desired behavior, if this is unneeded we should just delete the else branch.
push back getaddednodeinfo dead value 9c0bcb617b
jonasschnelli added the label RPC/REST/ZMQ on Apr 22, 2016
paveljanik commented at 9:04 PM on April 22, 2016: contributor

Looks like this was the original goal, yes.

utACK https://github.com/bitcoin/bitcoin/pull/7926/commits/9c0bcb617b7358006842900ad8a9b333b30f5031
sipa commented at 1:28 PM on April 23, 2016: member

utACK 9c0bcb6
laanwj commented at 3:19 PM on April 25, 2016: member

Yes, I've never used this RPC but this makes sense I think. I think the point is to add entries that failed lookup to the list but as non-connected. utACK https://github.com/bitcoin/bitcoin/pull/7926/commits/9c0bcb617b7358006842900ad8a9b333b30f5031
TheBlueMatt commented at 11:12 PM on April 25, 2016: member

utACK 9c0bcb617b7358006842900ad8a9b333b30f5031
laanwj merged this on Apr 28, 2016
laanwj closed this on Apr 28, 2016
laanwj referenced this in commit 5725807402 on Apr 28, 2016
DrahtBot locked this on Sep 8, 2021

Contributors

Labels