Minor changes for c++11 consistency #7964

pull laanwj wants to merge 2 commits into bitcoin:master from laanwj:2016_04_c++11_consistency changing 4 files +5 −5

laanwj commented at 11:44 AM on April 28, 2016: member
- Bitwise logic combined with < with undefined signedness will potentially result in undefined behavior. Fix this by defining the type as a c++11 typed enum. Fixes #6017.
- auto_ptr → unique_ptr: Change the few occurrences of the deprecated auto_ptr to c++11 unique_ptr. Silences the deprecation warnings.

chain: define enum used as bit field as uint32_t

Bitwise logic combined with `<` with undefined signedness will
potentially results in undefined behavior. Fix this by defining the type
as a c++11 typed enum.

Fixes #6017.

073225cb01

auto_ptr → unique_ptr

Change the few occurrences of the deprecated `auto_ptr` to c++11 `unique_ptr`.
Silences the deprecation warnings.

Also add a missing `std::` for consistency.

07e4edb056

laanwj added the label Refactoring on Apr 28, 2016
randy-waterhouse commented at 12:13 PM on April 28, 2016: contributor

ACK.
jonasschnelli commented at 12:27 PM on April 28, 2016: contributor

utACK 07e4edb056249e017b0e5a4783e4452ce892b52d
mruddy commented at 2:49 PM on April 28, 2016: contributor

utACK 07e4edb
paveljanik commented at 8:25 PM on April 28, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/commit/07e4edb056249e017b0e5a4783e4452ce892b52d
theuni commented at 9:12 PM on April 28, 2016: member

utACK 07e4edb056249e017b0e5a4783e4452ce892b52d
fanquake commented at 10:28 AM on May 1, 2016: member

utACK 07e4edb
btcdrak commented at 10:39 AM on May 1, 2016: contributor

utACK 07e4edb056249e017b0e5a4783e4452ce892b52d
dcousens commented at 1:18 AM on May 2, 2016: contributor

utACK 07e4edb
laanwj merged this on May 2, 2016
laanwj closed this on May 2, 2016
laanwj referenced this in commit 86b800c6a2 on May 2, 2016
zkbot referenced this in commit b0afc4ba1d on Mar 22, 2017
zkbot referenced this in commit f9f48667be on Mar 25, 2017
codablock referenced this in commit 91f679c2b2 on Sep 16, 2017
codablock referenced this in commit 2e6d495989 on Sep 19, 2017
codablock referenced this in commit a468803bd9 on Dec 20, 2017
DrahtBot locked this on Sep 8, 2021

Contributors

Labels

Linked (view graph)

#6017 Signedness of an Enum is undefined in standard C++