Some developers clearly don't get this and have been posting "improvements" that create clear vulnerabilities. It should have been better explained in the code, since the design is somewhat subtle and getting it right is important.
More comments on the design of AttemptToEvictConnection. #7974
pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:attempt_to_evict_comment changing 1 files +11 −2-
gmaxwell commented at 2:28 PM on April 29, 2016: contributor
- MarcoFalke added the label Docs and Output on Apr 29, 2016
-
d90351f050
More comments on the design of AttemptToEvictConnection.
Some developers clearly don't get this and have been posting "improvements" that create clear vulnerabilities. It should have been better explained in the code, since the design is somewhat subtle and getting it right is important.
-
pstratem commented at 2:33 AM on April 30, 2016: contributor
ACK d90351f0504c5d4057e560d64107a2f36d7bf3d4
- laanwj merged this on May 4, 2016
- laanwj closed this on May 4, 2016
- laanwj referenced this in commit 8206835cc1 on May 4, 2016
- codablock referenced this in commit ce39658527 on Sep 16, 2017
- codablock referenced this in commit ae66a4afdc on Sep 19, 2017
- codablock referenced this in commit 49c3127b55 on Dec 20, 2017
- DrahtBot locked this on Sep 8, 2021