More comments on the design of AttemptToEvictConnection. #7974

pull gmaxwell wants to merge 1 commits into bitcoin:master from gmaxwell:attempt_to_evict_comment changing 1 files +11 −2
  1. gmaxwell commented at 2:28 PM on April 29, 2016: contributor

    Some developers clearly don't get this and have been posting "improvements" that create clear vulnerabilities. It should have been better explained in the code, since the design is somewhat subtle and getting it right is important.

  2. MarcoFalke added the label Docs and Output on Apr 29, 2016
  3. gmaxwell commented at 11:06 PM on April 29, 2016: contributor

    @pstratem It's your code I'm commenting here.

  4. More comments on the design of AttemptToEvictConnection.
    Some developers clearly don't get this and have been posting
     "improvements" that create clear vulnerabilities.  It should
     have been better explained in the code, since the design
     is somewhat subtle and getting it right is important.
    d90351f050
  5. pstratem commented at 2:33 AM on April 30, 2016: contributor

    ACK d90351f0504c5d4057e560d64107a2f36d7bf3d4

  6. laanwj merged this on May 4, 2016
  7. laanwj closed this on May 4, 2016

  8. laanwj referenced this in commit 8206835cc1 on May 4, 2016
  9. codablock referenced this in commit ce39658527 on Sep 16, 2017
  10. codablock referenced this in commit ae66a4afdc on Sep 19, 2017
  11. codablock referenced this in commit 49c3127b55 on Dec 20, 2017
  12. DrahtBot locked this on Sep 8, 2021
Contributors
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me