Remove obsolete reference to CValidationState from UpdateCoins. #7976

ghost commented at 3:51 AM on April 30, 2016: none

I prefer, but do not insist on this. Might want to refactor the remaining dummy CTxUndo txundo; at some other time.

MarcoFalke added the label Refactoring on Apr 30, 2016

Remove obsolete reference to CValidationState from UpdateCoins. c8b92486c4

in src/main.h:None in 16dda8f3f1 outdated

 358 | @@ -359,7 +359,7 @@ bool CheckInputs(const CTransaction& tx, CValidationState &state, const CCoinsVi
 359 |                   unsigned int flags, bool cacheStore, std::vector<CScriptCheck> *pvChecks = NULL);
 360 |  
 361 |  /** Apply the effects of this transaction on the UTXO set represented by view */
 362 | -void UpdateCoins(const CTransaction& tx, CValidationState &state, CCoinsViewCache &inputs, int nHeight);
 363 | +void UpdateCoins(const CTransaction& tx, CCoinsViewCache &inputs, int nHeight);

MarcoFalke commented at 4:17 PM on April 30, 2016:

nit: If you do trivial fixes, please also do all other trivial fixes in the same line:

diff --git a/src/main.cpp b/src/main.cpp
index c5d2e23..7d5beab 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -1747 +1747 @@ void static InvalidBlockFound(CBlockIndex *pindex, const CValidationState &state
-void UpdateCoins(const CTransaction& tx, CCoinsViewCache &inputs, CTxUndo &txundo, int nHeight)
+void UpdateCoins(const CTransaction& tx, CCoinsViewCache& inputs, CTxUndo& txundo, int nHeight)
@@ -1773 +1773 @@ void UpdateCoins(const CTransaction& tx, CCoinsViewCache &inputs, CTxUndo &txund
-void UpdateCoins(const CTransaction& tx, CCoinsViewCache &inputs, int nHeight)
+void UpdateCoins(const CTransaction& tx, CCoinsViewCache& inputs, int nHeight)
diff --git a/src/main.h b/src/main.h
index 716378e..792747a 100644
--- a/src/main.h
+++ b/src/main.h
@@ -362 +362 @@ bool CheckInputs(const CTransaction& tx, CValidationState &state, const CCoinsVi
-void UpdateCoins(const CTransaction& tx, CCoinsViewCache &inputs, int nHeight);
+void UpdateCoins(const CTransaction& tx, CCoinsViewCache& inputs, int nHeight);