Conflicted transactions can get stuck at the top. This fixes that.
I'm willing to add a setting to allow the user to pick a default sort if necessary.
I got the idea for this from Theymos: https://www.reddit.com/r/Bitcoin/comments/4i396u/bitcoin_qt_feature_suggestions/d2uowpt
You should be able to just click the heading you want to sort by... maybe this makes sense as a default though.
Yeah, you can click to sort by column. The idea is that date makes a better default.
Yes. This makes sense. utACK 650222badaf95b7a91ce0c8aa50623359fa03380
With this, we will have a different default sort order in the main window (Overview - Recent transactions) and in the Transactions tab. This is not very intuitive.
Can you change the sort order there too?
With this, we will have a different default sort order in the main window (Overview - Recent transactions) and in the Transactions tab. This is not very intuitive.
Good point. I agree with @paveljanik.
Conflicted transactions can get stuck at the top. This fixes that.
@paveljanik, good catch! Thanks!
And yeah, it was also trivial to change.
utACK 2d5603c
Ready for merge.
On regtest this can result in a strange table ordering. If you generate a couple of blocks, mostly some (or all) of them are generated during the same second which makes them equal for the date sort order. My tests showed me, that I had transactions table entries (coinbase) with more confirmations on top of entries with fever confirmations.
I hope this is a regtest only problem (I can't imagine a mainnet use case where this issue could play a role).
Is there a possibility to use the amount of confirmations as second sort attribute (if the first sort attribute is equal)?
Conflicted transactions can get stuck at the top. This fixes that.
Wouldn't it be better to give an option to wipe such transactions from the db (and thus gui) entirely?
You can use the new abandon function (context menu) #7707. But it will not remove the transaction. Removing is somehow against the bookkeeping rules. But I agree it could be useful sometimes.
For this PR: I think it is useful. But confirmation count should be the 2nd sort attribute.
@jonasschnelli there's no builtin way to do that. I could add a method to do it, but I'm not sure how to expose the functionality API-wise.
What do you think about having a sortSecondary(int col, Qt::SortOrder ord) method that is called on a TransactionFilterProxy that has already been sorted by the primary key. This is the simplest way to implement it that I can think of.
Tested ACK. Further improvements (second sort attribute) can be done later.