improvement to readability #8031

pull smatthewenglish wants to merge 1 commits into bitcoin:master from smatthewenglish:patch-3 changing 1 files +1 −2

smatthewenglish commented at 12:01 PM on May 9, 2016: contributor

changing "(tests are) automatically run" to correspond to the earlier instance of "run automatically (on the build server)", also some minor grammatical modification
changing "(tests are) automatically run" to correspond to the earlier instance of "run automatically (on the build server)" fe80102d33
jonasschnelli added the label Docs and Output on May 9, 2016
paveljanik commented at 8:39 PM on May 9, 2016: contributor

Why?
smatthewenglish commented at 8:41 PM on May 9, 2016: contributor

because- it should be consistent- it's like code indentation- it could be inconsistent- but that's not good style
dcousens commented at 7:02 AM on May 10, 2016: contributor

utACK fe80102
MarcoFalke commented at 7:08 AM on May 10, 2016: member

utACK fe80102
fanquake commented at 8:24 AM on May 10, 2016: member

utACK fe80102

in README.md:None in fe80102d33

  56 | @@ -57,8 +57,7 @@ There are also [regression and integration tests](/qa) of the RPC interface, wri
  57 |  in Python, that are run automatically on the build server.
  58 |  These tests can be run (if the [test dependencies](/qa) are installed) with: `qa/pull-tester/rpc-tests.py`
  59 |  
  60 | -The Travis CI system makes sure that every pull request is built for Windows
  61 | -and Linux, OS X, and that unit and sanity tests are automatically run.
  62 | +The Travis CI system makes sure that every pull request is built for Windows, Linux, and OS X, and that unit/sanity tests are run automatically.

paveljanik commented at 9:51 AM on May 10, 2016:

Can you at least use shorter line? I somehow missed the difference in the second part of the sentence while reading the diff ;-)

MarcoFalke commented at 10:05 AM on May 10, 2016:

Note: You can toggle the Github rendered diff for .md files

laanwj merged this on May 18, 2016
laanwj closed this on May 18, 2016
laanwj referenced this in commit 457b9df6b5 on May 18, 2016
codablock referenced this in commit 08d2dd6c2e on Sep 16, 2017
codablock referenced this in commit ac962eb294 on Sep 19, 2017
codablock referenced this in commit 72bee9e555 on Dec 21, 2017
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels