[qa, doc] Various minor fixes #8038

1. 
   MarcoFalke commented at 3:56 pm on May 10, 2016: member

   • Disable salvagewallet check until #7463 is fixed
   • Update various docs …
2. Increase timeout waiting for pruned blk00000.dat

   In my ever-growing list of test failures, I was seeing this one intermittently.
   
   ```
   Running 2nd level testscript pruning.py...
   Initializing test directory /tmp/testY5ypCv
   Warning! This test requires 4GB of disk space and takes over 30 mins (up to 2 hours)
   Mining a big blockchain of 995 blocks
   Check that we haven't started pruning yet because we're below PruneAfterHeight
   Success
   Though we're already using more than 550MB, current usage: 587
   Mining 25 more blocks should cause the first block file to be pruned
   Assertion failed: blk00000.dat not pruned when it should be
     File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/test_framework/test_framework.py", line 118, in main
       self.run_test()
     File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 272, in run_test
       self.test_height_min()
     File "/home/error/bitcoinxt-0.11D/qa/rpc-tests/pruning.py", line 94, in test_height_min
       raise AssertionError("blk00000.dat not pruned when it should be")
   Stopping nodes
   Failed
   ```
   
   After digging into the test, I found that the code is waiting 10 seconds for blk00000.dat to be deleted, and then throwing this failure if it still exists after 10 seconds.
   
   I increased this amount, had the script print the actual time taken, and ran the test a few more times. The time taken ranged between 8 to 12 seconds. So, I feel that this timeout is too short.
   
   After changing the timeout to 30 seconds, the test passes consistently.
   (cherry picked from commit 3469911c89a48dd2fefe4d1c2a0c176256e14ee0)

   ac40ed7800
3. MarcoFalke added the label Refactoring on May 10, 2016
4. MarcoFalke added the label Docs and Output on May 10, 2016
5. [doc] Remove outdated line from listunspent RPC help, fix typo fa72f7d99d
6. [doc] Link to clang-format in the developer notes fadd048592
7. MarcoFalke force-pushed on May 10, 2016
8. [qa] wallet: Temporarily disable salvagewallet test fa83a5dbce
9. in qa/rpc-tests/wallet.py: in fa4458e1c4 outdated

   305@@ -306,7 +306,7 @@ def run_test (self):
   306         # Check that the txid and balance is found by node1
   307         self.nodes[1].gettransaction(cbTxId)
   308 
   309-        #check if wallet or blochchain maintenance changes the balance
   310+        # check if wallet or blochchain maintenance changes the balance
   

   ---

   ---

   

   paveljanik commented at 4:01 pm on May 10, 2016:

   s/blochchain/blockchain/
10. MarcoFalke force-pushed on May 10, 2016
11. 
    laanwj commented at 9:32 am on May 12, 2016: member

    utACK
12. 
    fanquake commented at 11:20 am on May 12, 2016: member

    utACK
13. MarcoFalke removed the label Refactoring on May 14, 2016
14. MarcoFalke added the label Tests on May 14, 2016
15. MarcoFalke merged this on May 17, 2016
16. MarcoFalke closed this on May 17, 2016

    ---

17. MarcoFalke referenced this in commit e2bf830bb6 on May 17, 2016
18. MarcoFalke deleted the branch on May 17, 2016
19. ftrader referenced this in commit 5ba022fab1 on Dec 9, 2016
20. codablock referenced this in commit a5ae8f116f on Sep 16, 2017
21. codablock referenced this in commit 339716f1c4 on Sep 19, 2017
22. codablock referenced this in commit a0afc3ee01 on Dec 21, 2017
23. MarcoFalke locked this on Sep 8, 2021

Contributors
MarcoFalke paveljanik laanwj fanquake

Labels
Docs Tests