[Qt] Don't allow to open the debug window during splashscreen & verification state #8042

pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/05/qt_debug_win_splash changing 2 files +13 −0
  1. jonasschnelli commented at 7:18 PM on May 11, 2016: contributor

    Fixes #8040. The debug window can't handle the block verification state during startup (see #8040).

    Disabling the debug window until the main application window shows up seems to be a easy and stable solution.

  2. jonasschnelli added the label GUI on May 11, 2016
  3. Tyler-Hardin commented at 7:32 PM on May 11, 2016: contributor

    Do we want to show the menu at all before the app is done initializing?

    I think if we swap lines 662 and 663 in bitcoin.cpp the menu won't be created until initialization is done. (But I don't have a Mac to test on.)

    app.requestInitialize();
    app.createWindow(networkStyle.data());
    

    EDIT: Nvm, it'll take more than that. Asynchronous code is hard.

  4. jonasschnelli commented at 7:40 PM on May 11, 2016: contributor

    @Tyler-Hardin: Right. And OSX is also picky with the main menu. I'm pretty sure removing the menu will lead into losing the Ctrl-Q / quit option during the startup/splashscreen state.

    The menu itself doesn't hurt during the splash screen. It would just require some work to make the debug window compatible for that state (which is not worth doing that why I propose this PR/simple fix).

  5. fanquake commented at 5:54 AM on May 12, 2016: member

    Tested ACK 29199ad on OS X

    However, given that preferences and About bitcoin-qt are clickable, but no window actually shows, do we want to disable those until initialisation is finished as well?

  6. jonasschnelli force-pushed on May 12, 2016
  7. [Qt] Disable some menu items during splashscreen/verification state 276ce84fd3
  8. jonasschnelli force-pushed on May 12, 2016
  9. jonasschnelli commented at 8:45 AM on May 12, 2016: contributor

    Good point @fanquake! I have now disabled the about menu as well as the options menu. Can you re-test?

  10. fanquake commented at 9:14 AM on May 12, 2016: member

    @jonasschnelli Looks good. main debug Tested ACK 276ce84

  11. laanwj commented at 9:27 AM on May 12, 2016: member

    The menu is supposed to be a property of the main window, it is not supposed to show a menu at all during the splash screen. Is is possible to fix this more thoroughly instead of disabling individual actions? I can easily see this become a problem again in the future when someone adds an action.

  12. jonasschnelli commented at 2:32 PM on May 12, 2016: contributor

    On OSX, you will always have a menu bar.

    Minimum menu bar would be: <img width="192" alt="bildschirmfoto 2016-05-12 um 13 26 19" src="https://cloud.githubusercontent.com/assets/178464/15218179/fb7c9c0a-185e-11e6-82fe-10f06fca8171.png">

    IMO disabling "about" and "debug window" would look better.

  13. MarcoFalke added the label MacOSX on May 12, 2016
  14. jonasschnelli merged this on May 23, 2016
  15. jonasschnelli closed this on May 23, 2016

  16. jonasschnelli referenced this in commit 692971193a on May 23, 2016
  17. MarcoFalke referenced this in commit fe98533b40 on Jul 4, 2016
  18. nomnombtc referenced this in commit a97a024735 on Nov 12, 2016
  19. nomnombtc referenced this in commit e8c08d99be on Nov 12, 2016
  20. nomnombtc referenced this in commit 22c52b5a49 on Nov 13, 2016
  21. sickpig referenced this in commit ccdcef7bb2 on Nov 14, 2016
  22. barton2526 referenced this in commit fc2c24a21d on Jul 22, 2021
  23. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 09:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me