travis: use slim generic image, and some fixups #8067

pull theuni wants to merge 1 commits into bitcoin:master from theuni:travis-generic-image changing 1 files +26 −37

theuni commented at 1:30 AM on May 18, 2016: member
Now that caches are distinct (https://github.com/travis-ci/travis-ci/issues/4393), we can use the Travis minimal image. The minimal image should take less time to setup and lead to quicker builds.

Also addressed while I'm in here:
- No need to delete the broken google-chrome repo in the minimal image
- Set the hostname to work-around an openjdk bug
- Remove the non-functional apt-cache option
- Remove useless message at completion
- Install jre where the java tests are run
- 'make check' in parallel, since the log will take care of clean output
- 'make check' verbose, so that test failure causes aren't hidden

laanwj commented at 8:40 AM on May 18, 2016: member

Concept ACK.

Travis failure is extremely scary:

02:08:15 1 H2FullPrunedBlockStore.<init>: org.h2.Driver loaded. 
*** buffer overflow detected ***: /usr/bin/java terminated

fanquake commented at 12:52 PM on May 18, 2016: member

@laanwj The use of the hostname addon is meant to prevent that issue, so the workaround might not be working as expected. More info about it can be found here

Concept ACK, glad to see the caching issue finally sorted.
MarcoFalke added the label Build system on May 18, 2016

in .travis.yml:None in 86b66da2bf outdated

  69 | @@ -78,9 +70,8 @@ script:
  70 |      - ./configure --cache-file=../config.cache $BITCOIN_CONFIG_ALL $BITCOIN_CONFIG || ( cat config.log && false)
  71 |      - make $MAKEJOBS $GOAL || ( echo "Build failure. Verbose build follows." && make $GOAL V=1 ; false )
  72 |      - export LD_LIBRARY_PATH=$TRAVIS_BUILD_DIR/depends/$HOST/lib
  73 | -    - if [ "$RUN_TESTS" = "true" ]; then make check; fi
  74 | +    - if [ "$RUN_TESTS" = "true" ]; then make $MAKEJOBS check VERBOSE=1; fi

MarcoFalke commented at 3:44 PM on May 20, 2016:

I've already merged this, because I am not sure how long this pull will be in the review queue.

You could try a rebase once travis is running again to get rid of this patch and also trigger a build.

theuni force-pushed on May 21, 2016

travis: use slim generic image, and some fixups

Now that caches are distinct (https://github.com/travis-ci/travis-ci/issues/4393),
we can use the Travis minimal image.
The minimal image should take less time to setup and lead to quicker builds.

Also addressed while I'm in here:
- No need to delete the broken google-chrome repo in the minimal image
- Set the hostname to work-around an openjdk bug
- Remove the non-functional apt-cache option
- Remove useless message at completion
- Install jre where the java tests are run

2ca8962a09

theuni force-pushed on May 21, 2016
arowser commented at 8:43 AM on May 25, 2016: contributor

Can one of the admins verify this patch?
laanwj commented at 6:10 AM on May 26, 2016: member

Looks like the workaround for the work-around is still failing travis :(
laanwj commented at 4:26 PM on June 6, 2016: member

Tried to retrigger travis, still fails
theuni force-pushed on Jun 9, 2016
theuni commented at 5:49 PM on June 9, 2016: member

Ready for review now, the upstream issue has been resolved.
laanwj commented at 1:39 PM on June 10, 2016: member

Travis results look good @ https://travis-ci.org/bitcoin/bitcoin/builds/136465746. ACK https://github.com/bitcoin/bitcoin/pull/8067/commits/2ca8962a095ee29709316d163508f26ab1c340ae
laanwj merged this on Jun 10, 2016
laanwj closed this on Jun 10, 2016
laanwj referenced this in commit 3e4cf8fe26 on Jun 10, 2016
fanquake commented at 1:42 PM on June 10, 2016: member

Post merge utACK 2ca8962a095ee29709316d163508f26ab1c340ae
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels