Add req- prefixes to comply with BIP21. #807

pull TheBlueMatt wants to merge 2 commits into bitcoin:master from TheBlueMatt:bip21 changing 6 files +133 −10

TheBlueMatt commented at 6:47 pm on February 7, 2012: member
TheBlueMatt commented at 8:40 pm on February 7, 2012: member

No, the original intent was that req- prefixes are optional and can be applied to any params. ie a merchant may want to enforce or not enforce an expires param. That should be clarified in the bip. (see https://github.com/genjix/bips/pull/4)
laanwj commented at 11:08 am on February 9, 2012: member
In that case should there be a
0fShouldReturnFalse = false;
in the amount handling?
TheBlueMatt commented at 5:38 pm on February 9, 2012: member

Heh, oops…fixed
gavinandresen commented at 5:09 pm on February 10, 2012: contributor

This is the type of code that aught to have unit tests. I don’t know nuthin about unit testing with Qt; is it easy to get qmake to compile unit tests, and/or is there support in Qt for unit tests?
TheBlueMatt commented at 10:30 pm on February 10, 2012: member

Still gotta add a ton more test, but I put in a bitcoin-qt test suite structure. Just build with qmake bitcoin-qt.pro BITCOIN_QT_TEST=1; make you should then find a bitcoin-qt_test exe to call
Add -req prefixes to comply with BIP21. cce89ead18
Add Bitcoin-Qt test suite with some bitcoin: URL Tests to start. 245484679a
TheBlueMatt commented at 10:47 pm on February 10, 2012: member

OK, there we go, test away.
laanwj commented at 8:44 am on February 11, 2012: member

ACK, nice tests
laanwj referenced this in commit 15b87b2ec4 on Feb 12, 2012
laanwj merged this on Feb 12, 2012
laanwj closed this on Feb 12, 2012
coblee referenced this in commit de27e17aa1 on Jul 17, 2012
destenson referenced this in commit e689138081 on Jun 26, 2016
pull[bot] referenced this in commit 05623c0216 on Jul 8, 2019
jasonbcox referenced this in commit 3bee3612dd on Oct 9, 2020
DrahtBot locked this on Sep 8, 2021

Contributors
TheBlueMatt laanwj gavinandresen

Milestone
V0.6