Add req- prefixes to comply with BIP21. #807

1. 
   TheBlueMatt commented at 6:47 PM on February 7, 2012: member

   No description provided.

2. 
   TheBlueMatt commented at 8:40 PM on February 7, 2012: member

   No, the original intent was that req- prefixes are optional and can be applied to any params. ie a merchant may want to enforce or not enforce an expires param. That should be clarified in the bip. (see https://github.com/genjix/bips/pull/4)

3. 
   laanwj commented at 11:08 AM on February 9, 2012: member

   In that case should there be a

   fShouldReturnFalse = false;
   

   in the amount handling?

4. 
   TheBlueMatt commented at 5:38 PM on February 9, 2012: member

   Heh, oops...fixed

5. 
   gavinandresen commented at 5:09 PM on February 10, 2012: contributor

   This is the type of code that aught to have unit tests. I don't know nuthin about unit testing with Qt; is it easy to get qmake to compile unit tests, and/or is there support in Qt for unit tests?

6. 
   TheBlueMatt commented at 10:30 PM on February 10, 2012: member

   Still gotta add a ton more test, but I put in a bitcoin-qt test suite structure. Just build with qmake bitcoin-qt.pro BITCOIN_QT_TEST=1; make you should then find a bitcoin-qt_test exe to call

7. Add -req prefixes to comply with BIP21. cce89ead18
8. Add Bitcoin-Qt test suite with some bitcoin: URL Tests to start. 245484679a
9. 
   TheBlueMatt commented at 10:47 PM on February 10, 2012: member

   OK, there we go, test away.

10. 
    laanwj commented at 8:44 AM on February 11, 2012: member

    ACK, nice tests

11. laanwj referenced this in commit 15b87b2ec4 on Feb 12, 2012
12. laanwj merged this on Feb 12, 2012
13. laanwj closed this on Feb 12, 2012

    ---

14. coblee referenced this in commit de27e17aa1 on Jul 17, 2012
15. destenson referenced this in commit e689138081 on Jun 26, 2016
16. pull[bot] referenced this in commit 05623c0216 on Jul 8, 2019
17. jasonbcox referenced this in commit 3bee3612dd on Oct 9, 2020
18. DrahtBot locked this on Sep 8, 2021

Milestone
V0.6