Test framework: only cleanup on successful test runs #8095

pull sdaftuar wants to merge 1 commits into bitcoin:master from sdaftuar:nocleanup-on-failure changing 1 files +3 −1

sdaftuar commented at 3:37 PM on May 24, 2016: member

Don't cleanup the datadir's on test failure.

I hope that this should make it easier to debug rare-failing tests, as we'll at least have the debug.log's available to go through. @MarcoFalke: After this, we could perhaps add to the rpc-tests.py script some functionality to tail the last few hundred lines of debug.log for each node if a test fails, so that if a job fails in travis, we'll have more info to look at?
jtimon commented at 4:23 PM on May 24, 2016: contributor

ACK
paveljanik commented at 4:54 PM on May 24, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/8095/commits/64fc92f88309754184fd0006998b7c5d6c709752
MarcoFalke commented at 6:16 PM on May 24, 2016: member

Concept ACK. Wouldn't it make sense to also print("Not cleaning up dir %s" % self.options.tmpdir)?

Tailing the debug.log from rpc_tests.py makes sense, but would at least require #8098.
btcdrak commented at 6:20 PM on May 24, 2016: contributor

utACK 64fc92f
jtimon commented at 9:11 AM on May 25, 2016: contributor

@arowser why are you asking the same question in so many random PRs?

This is disruptive or development and annoying. Please, stop.
sdaftuar force-pushed on May 25, 2016
sdaftuar commented at 9:42 AM on May 25, 2016: member

@MarcoFalke Updated with the print statement as suggested.
Test framework: only cleanup on successful test runs 1ad9339508
MarcoFalke commented at 9:47 AM on May 25, 2016: member

utACK 1ad9339
jtimon commented at 9:52 AM on May 25, 2016: contributor

ACK 1ad9339
MarcoFalke merged this on May 25, 2016
MarcoFalke closed this on May 25, 2016
MarcoFalke referenced this in commit 6700cc993c on May 25, 2016
codablock referenced this in commit 3f3ce4c321 on Sep 16, 2017
codablock referenced this in commit a369fbb13f on Sep 19, 2017
codablock referenced this in commit f50b8bf669 on Dec 21, 2017
sickpig referenced this in commit 101c642563 on Mar 9, 2018
sickpig referenced this in commit a889a3d9a3 on Mar 9, 2018
sickpig referenced this in commit ed5b5eac84 on Mar 12, 2018
sickpig referenced this in commit 4f85eca0f9 on Mar 12, 2018
sickpig referenced this in commit c30f7fcaa7 on Mar 12, 2018
sickpig referenced this in commit 40bc0128d2 on Mar 12, 2018
sickpig referenced this in commit 330553f4a5 on Mar 12, 2018
DrahtBot locked this on Sep 8, 2021

Contributors

Labels