This makes it possible to specify a tmpdir while running tests in parallel.
[qa] test_framework: Append portseed to tmpdir #8098
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1605-qatmpdir changing 1 files +2 −0-
MarcoFalke commented at 6:11 PM on May 24, 2016: member
-
fa57b0c5ef
[qa] test_framework: Append portseed to tmpdir
This makes it possible to specify a tmpdir while running tests in parallel
- MarcoFalke assigned MarcoFalke on May 24, 2016
-
sdaftuar commented at 9:59 AM on May 25, 2016: member
How about a '.' in the name to separate dirname and port_seed, rather than a '/' for a new directory? Seems like tab-completion would work better that way.
-
MarcoFalke commented at 3:44 PM on May 26, 2016: member
@sdaftuar Can you explain how this helps tab-completion? I fail to see the difference in the '.' vs '/'.
Also, this would mean to adjust the
--tmpdirhelp tohelp="Path prefix for datadirs. (portseed is appended to the prefix)". -
sdaftuar commented at 4:35 PM on May 26, 2016: member
@MarcoFalke Ah I hadn't thought about the --tmpdir argument requiring us to use space inside that directory tree, that's a fair point. I was just thinking that I have to press [tab] one extra time to tab-complete to a subdirectory, maybe that's unique to my shell/environment, but not a big deal.
ACK
-
sipa commented at 10:29 PM on May 26, 2016: member
Concept ACK
- MarcoFalke merged this on May 27, 2016
- MarcoFalke closed this on May 27, 2016
- MarcoFalke referenced this in commit 06bd4f637f on May 27, 2016
- MarcoFalke deleted the branch on May 27, 2016
- codablock referenced this in commit b0ebd6a917 on Sep 16, 2017
- codablock referenced this in commit 0be90f350f on Sep 19, 2017
- codablock referenced this in commit 7db5be442a on Dec 21, 2017
- andvgal referenced this in commit 656bcc4c9c on Jan 6, 2019
- zkbot referenced this in commit 025bd44543 on Nov 21, 2020
- zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
- zkbot referenced this in commit c8896f9907 on Dec 2, 2020
- MarcoFalke locked this on Sep 8, 2021
Contributors
Labels