comment nit: miners don't vote #8143

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:notavote changing 1 files +2 −2

instagibbs commented at 2:08 PM on June 3, 2016: member

No description provided.
comment nit: miners don't vote e39dc698ad
MarcoFalke added the label Docs and Output on Jun 3, 2016
gmaxwell commented at 3:20 PM on June 3, 2016: contributor

ACK.
MarcoFalke commented at 3:39 PM on June 3, 2016: member

ACK e39dc69
jonasschnelli commented at 5:56 PM on June 3, 2016: contributor

ACK e39dc698adf46dc3306526971ca6f0f6401f30ca

in src/main.cpp:None in e39dc698ad

1885 | @@ -1886,8 +1886,8 @@ bool CheckInputs(const CTransaction& tx, CValidationState &state, const CCoinsVi
1886 |                      // such nodes as they are not following the protocol. That
1887 |                      // said during an upgrade careful thought should be taken
1888 |                      // as to the correct behavior - we may want to continue
1889 | -                    // peering with non-upgraded nodes even after a soft-fork
1890 | -                    // super-majority vote has passed.
1891 | +                    // peering with non-upgraded nodes even after soft-fork
1892 | +                    // super-majority signaling has occurred.

paveljanik commented at 7:44 PM on June 3, 2016:

Sorry for being a nit-picker again, but isn't "signalling" the correct spelling?

instagibbs commented at 7:52 PM on June 3, 2016:

it's 'Murika spelling, apologies

paveljanik commented at 7:44 PM on June 3, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/8143/commits/e39dc698adf46dc3306526971ca6f0f6401f30ca
jonasschnelli merged this on Jun 4, 2016
jonasschnelli closed this on Jun 4, 2016
jonasschnelli referenced this in commit d46b8b50fc on Jun 4, 2016
codablock referenced this in commit 1e9c3a251e on Sep 16, 2017
codablock referenced this in commit c573d91c5b on Sep 19, 2017
codablock referenced this in commit 7538795b1f on Dec 22, 2017
andvgal referenced this in commit 9433059f22 on Jan 6, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels