WIP: OSX toolchain bump #8184

1. 
   theuni commented at 5:44 pm on June 9, 2016: member

   This bumps us to:

   • SDK: 10.11
   • clang: 3.7.1
   • cctools: 877.8
   • ld64: 253.9

   Beyond just keeping us current, this is also necessary for #7770. The bump doesn’t change anything in terms of back-compat, we still specify 10.7 as the required minimum.

   Todo before merge:

   • Depends on #8053. The qt change here should be reverted after that.
   • I need to thoroughly review the cctools/ld64 bump, this was just a quick port.
   • Docs need to be updated to reflect the switch to 10.11 sdk.
2. depends: bump OSX toolchain

   clang: 3.7.1
   cctools: 877.8
   ld64: 253.9

   ad615f7ac1
3. build: osx: bump travis/gitian to 10.11 SDK f5ade22e22
4. in depends/packages/qt.mk: in f5ade22e22

   123@@ -124,6 +124,7 @@ define $(package)_preprocess_cmds
   124   sed -i.old "s/src_plugins.depends = src_sql src_xml src_network/src_plugins.depends = src_xml src_network/" qtbase/src/src.pro && \
   125   sed -i.old "s|X11/extensions/XIproto.h|X11/X.h|" qtbase/src/plugins/platforms/xcb/qxcbxsettings.cpp && \
   126   sed -i.old 's/if \[ "$$$$XPLATFORM_MAC" = "yes" \]; then xspecvals=$$$$(macSDKify/if \[ "$$$$BUILD_ON_MAC" = "yes" \]; then xspecvals=$$$$(macSDKify/' qtbase/configure && \
   127+  sed -i.old 's/CGEventCreateMouseEvent(0, kCGEventMouseMoved, pos, 0)/CGEventCreateMouseEvent(0, kCGEventMouseMoved, pos, kCGMouseButtonLeft)/' qtbase/src/plugins/platforms/cocoa/qcocoacursor.mm && \
   

   ---

   ---

   

   jonasschnelli commented at 6:38 pm on June 9, 2016:

   hmm… what’s the patch for? IMO the kCGMouseButtonLeft constant is set to 0 as well? https://developer.apple.com/library/mac/documentation/Carbon/Reference/QuartzEventServicesRef/index.html#//apple_ref/c/econst/kCGMouseButtonLeft

   ---

   

   theuni commented at 8:30 pm on June 9, 2016:

   See the todo in description, this was fixed in 5.6.

   You’d have to cast like (CGMouseButton)0.

5. 
   jonasschnelli commented at 6:42 pm on June 9, 2016: contributor

   Nice! utACK f5ade22e2200d729a2cec1e95a5aaa98fcb41364. Started a OSX only gitian build here: https://bitcoin.jonasschnelli.ch/pulls/8184/

   I can take care of the docs.

   Question: would it be to restrictive to set 10.8 as minimum deployment version (OSX_MIN_VERSION)? It would allow us to get rid of some hack in https://github.com/bitcoin/bitcoin/blob/master/src/qt/macnotificationhandler.mm?

6. jonasschnelli added the label MacOSX on Jun 9, 2016
7. jonasschnelli added the label Build system on Jun 9, 2016
8. 
   theuni commented at 8:37 pm on June 9, 2016: member

   @jonasschnelli afaik 10.7 is the pretty standard minimum these days, but we could always bump if desired. It doesn’t look like that runtime check really hurts anything, though?
9. 
   fanquake commented at 5:08 am on June 10, 2016: member

   @jonasschnelli Is that the only 10.8 related hack in the codebase?
10. 
    jonasschnelli commented at 6:50 am on June 10, 2016: contributor

    @fanquake: bumping to 10.8 could allow use to use the NSNotificationCenter without weak linking.

    But after thinking about it, I guess we should keep 10.7 as min for 0.13 (maybe also for 0.14).

11. 
    jonasschnelli commented at 9:43 am on June 10, 2016: contributor

    Tested ACK f5ade22e2200d729a2cec1e95a5aaa98fcb41364.

    Did a gitian build, ran binaries on 10.11 and on a 10.07 machine:

12. 
    laanwj commented at 1:29 pm on June 10, 2016: member

    Question: would it be to restrictive to set 10.8 as minimum deployment version (OSX_MIN_VERSION)? It would allow us to get rid of some hack in

    I think that’s a pretty weak reason to drop support for an OS version. I’d also say stick with 10.7 as minimum for the foreseeable future.

13. 
    fanquake commented at 5:17 am on June 12, 2016: member

    I’ve put together some changes to the build-notes here if you’d like to cherry pick.

    The 10.11 SDK is first available in Xcode 7.1, any opinions on wether we should target that for the new download vs 7.3.1 ?

14. 
    laanwj commented at 11:35 am on June 20, 2016: member

    Closing in favor of #8210 @fanquake Probably want to PR those separately
15. MarcoFalke added this to the milestone 0.13.0 on Jun 20, 2016
16. MarcoFalke removed this from the milestone 0.13.0 on Jun 20, 2016
17. laanwj closed this on Jun 20, 2016

    ---

18. DrahtBot locked this on Sep 8, 2021

Contributors
theuni jonasschnelli fanquake laanwj

Labels
macOS Build system