[trivial] Remove URLs from About dialog translations #8192

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:source-code-link changing 1 files +3 −3

fanquake commented at 3:30 AM on June 12, 2016: member

Remove URLs from the strings in the About dialog.
jonasschnelli added the label GUI on Jun 12, 2016
jonasschnelli commented at 8:47 AM on June 12, 2016: contributor

ACK 78e3d1dcfed97eeb3db2f776e1683ed277098904

in src/init.cpp:None in 78e3d1dcfe outdated

 483 | @@ -484,6 +484,8 @@ std::string LicenseInfo()
 484 |             "\n" +
 485 |             _("This is experimental software.") + "\n" +
 486 |             "\n" +
 487 | +           _("The source code is available from <https://github.com/bitcoin/bitcoin>.") + "\n" +

MarcoFalke commented at 10:39 AM on June 12, 2016:

Please move the url out of the string to be translated.

paveljanik commented at 7:45 PM on June 12, 2016:

The URLs are used several lines down in the same file...

laanwj commented at 6:01 AM on June 13, 2016: member

Concept ACK, Agreed it would be better to not have the URL in the translation message: wouldn't want translators to be able to easily accidentally or on purpose, misdirect people here.
fanquake commented at 6:05 AM on June 13, 2016: member

@laanwj While we're editing the About dialog, should I remove the URLs from the other translations?
paveljanik commented at 6:28 AM on June 13, 2016: contributor

If you do so, please remember to use %s (or something similar) so translators can move the position of the URL in the sentence.
btcdrak commented at 7:00 AM on June 13, 2016: contributor

Would be nice to have a link to the project website too, bitcoincore.org
MarcoFalke commented at 7:07 AM on June 13, 2016: member

I think you can keep the other translations, as they already have great coverage over a lot of languages. The advantage of just extracting the url isnt worth it.

On Monday, June 13, 2016, Michael Ford notifications@github.com wrote:

@laanwj While we're editing the About dialog, should I remove the URLs from the other translations?
fanquake force-pushed on Jun 13, 2016
laanwj commented at 8:08 AM on June 13, 2016: member

We should aim to touch the translations only where necessary, as we're so close to a relase. (but if you have to touch those strings already, feel free to factor out the URLs)

If you do so, please remember to use %s (or something similar) so translators can move the position of the URL in the sentence.

It's unfortunate that neither Qt nor strprintf has named variables in string interpolation like Python's %(git_url)s.

in src/init.cpp:None in 0314ea79d0 outdated

 486 |             "\n" +
 487 | -           _("Distributed under the MIT software license, see the accompanying file COPYING or <http://www.opensource.org/licenses/mit-license.php>.") + "\n" +
 488 | +           strprintf(_("The source code is available from %s"), "<https://github.com/bitcoin/bitcoin>") + "\n" +
 489 |             "\n" +
 490 | -           _("This product includes software developed by the OpenSSL Project for use in the OpenSSL Toolkit <https://www.openssl.org/> and cryptographic software written by Eric Young and UPnP software written by Thomas Bernard.") +
 491 | +           strprintf(_("Distributed under the MIT software license, see the accompanying file COPYING or %s"), "<https://opensource.org/licenses/MIT>") + "\n" +

MarcoFalke commented at 11:47 AM on June 13, 2016:

Translation string freeze is in three days. Let's not invalidate all translations because the URL changed slightly. (The redirect still works fine)

Let's leave this for 0.14.0 or later. Also, the file name (COPYING) should be parametrized in the same go.

in src/init.cpp:None in 0314ea79d0 outdated

 488 | +           strprintf(_("The source code is available from %s"), "<https://github.com/bitcoin/bitcoin>") + "\n" +
 489 |             "\n" +
 490 | -           _("This product includes software developed by the OpenSSL Project for use in the OpenSSL Toolkit <https://www.openssl.org/> and cryptographic software written by Eric Young and UPnP software written by Thomas Bernard.") +
 491 | +           strprintf(_("Distributed under the MIT software license, see the accompanying file COPYING or %s"), "<https://opensource.org/licenses/MIT>") + "\n" +
 492 | +           "\n" +
 493 | +           strprintf(_("This product includes software developed by the OpenSSL Project for use in the OpenSSL Toolkit %s and cryptographic software written by Eric Young and UPnP software written by Thomas Bernard."), "<https://www.openssl.org>") +

MarcoFalke commented at 11:48 AM on June 13, 2016:

If you really want to change this here, please make sure OpenSSL is shown in qt but not in the daemon. Otherwise, it is probably good enough to just leave it for 0.14.

laanwj commented at 12:58 PM on June 13, 2016:

I don't think that would be correct yet - remember we still use OpenSSL for random number generation

MarcoFalke commented at 1:05 PM on June 13, 2016:

I had the impression this was already done

But there is still the issue open: #7162

jonasschnelli commented at 1:37 PM on June 13, 2016:

openSSL is still used for PRNG and BIP70 (Qt only). The later will be quasi impossible without openssl, but, it's used through Qt, not sure if we need to mention the license when using it "through" Qt.

fanquake force-pushed on Jun 14, 2016
fanquake commented at 4:49 AM on June 14, 2016: member

I've updated this to include "COPYING". Seems that consensus is that this is to much of a burden on translators this close to a release, so lets tag for 0.14.0 and merge later?
MarcoFalke commented at 6:46 AM on June 14, 2016: member

fanquake, what I was trying to say is that it would be fine to just add the new line (with the link to our repo) but keep all other lines as they are for now.

Adding the link could go into .13, all other can be done when we actually got rid of the ossl prng. (maybe .14, maybe .15)
jonasschnelli commented at 7:25 AM on June 15, 2016: contributor

Should we merge this post 0.13 to not break the current translations?
fanquake commented at 8:13 AM on June 16, 2016: member

@jonasschnelli I think that's the best case.
MarcoFalke added this to the milestone 0.14 on Jun 16, 2016
MarcoFalke commented at 8:59 AM on June 16, 2016: member

Assigned 0.14. Needs rebase.
fanquake force-pushed on Jun 16, 2016
fanquake renamed this:
~~[trivial] Add a link to the Bitcoin-Core repository to the About Dialog~~
[trivial] Remove URLs from About dialog translations
on Jun 16, 2016
fanquake commented at 12:08 PM on June 16, 2016: member

rebased
[trivial] Remove URLs from About dialog translations 208d37f116
fanquake force-pushed on Jul 21, 2016
jonasschnelli merged this on Aug 15, 2016
jonasschnelli closed this on Aug 15, 2016
jonasschnelli referenced this in commit c503863150 on Aug 15, 2016
MarcoFalke added the label Docs and Output on Aug 15, 2016
fanquake deleted the branch on Aug 15, 2016
codablock referenced this in commit 8929c62d72 on Sep 19, 2017
codablock referenced this in commit 0b3385dab8 on Dec 29, 2017
codablock referenced this in commit a377499c10 on Jan 8, 2018
andvgal referenced this in commit cbc9e082fc on Jan 6, 2019
MarcoFalke referenced this in commit 3f826598a4 on Mar 5, 2020
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels

Milestone
0.14.0

Linked (view graph)

#8207 [trivial] Add a link to the Bitcoin-Core repository and website to the About Dialog #17972 tests: Add fuzzing harness for CKey and key related functions #30476 scriptpubkeyman fuzz target TopUp is slow