This is being generated since #8188, should it be in .gitignore?
[trivial] Ignore split-debug.sh #8197
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:ignore-split-debug changing 1 files +1 −0-
fanquake commented at 11:46 AM on June 13, 2016: member
-
[trivial] Ignore split-debug.sh 01a99046de
- MarcoFalke added the label Docs and Output on Jun 13, 2016
-
droark commented at 12:26 AM on June 14, 2016: contributor
Hmmm. Haven't run this but, going off my recollection of Gitian builds (haven't done one in awhile), all the stuff built in a Gitian container is self-contained and built away from the normal directory structure. So, I don't think this patch is necessary. Nice thought, though, and I could be totally wrong. :)
-
laanwj commented at 6:58 AM on June 14, 2016: member
@droark You would be right if
split-debug.shwas only generated by the gitian descriptors. However the build system itself generates the file, so it does have to be ignored, as that's how we define the contents of.gitignorein this project.(@sipa is right and it is not "necessary" to do so, however it prevents this generated file from accidentally being checked in)
- laanwj merged this on Jun 14, 2016
- laanwj closed this on Jun 14, 2016
- laanwj referenced this in commit 8c1d5ebd17 on Jun 14, 2016
-
droark commented at 7:51 AM on June 14, 2016: contributor
@laanwj @sipa - Thanks for the correction. What I meant with my original comment was that I was under the impression that the generated file wouldn't be picked up in the original directory, and that .gitignore didn't have to be updated. (Obviously, .gitignore and Gitian are unrelated. I didn't mean to imply that.) I was wrong, though. C'est la vie. :)
- fanquake deleted the branch on Jun 22, 2016
- codablock referenced this in commit ef39a3a47f on Sep 16, 2017
- codablock referenced this in commit f378f85947 on Sep 19, 2017
- codablock referenced this in commit 74898b688c on Dec 27, 2017
- codablock referenced this in commit 2b4e896f60 on Dec 28, 2017
- andvgal referenced this in commit 7fc097da39 on Jan 6, 2019
- MarcoFalke locked this on Sep 8, 2021