Draft4 of ax_pthread has been available since February, and is the current version available from gnu.org. It fixes an issue on FreeBSD, so sync our version with upstream.
[trivial] Sync ax_pthread with upstream draft4 #8198
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:sync-pthread changing 1 files +275 −275-
fanquake commented at 12:13 PM on June 13, 2016: member
-
[trivial] Sync ax_pthread with upstream draft 0e209f9bf9
- MarcoFalke added the label Build system on Jun 13, 2016
-
paveljanik commented at 8:16 PM on June 13, 2016: contributor
The non-shitespaced diff https://github.com/bitcoin/bitcoin/pull/8198/commits/0e209f9bf940ec2f6215885cf30deaa7355086e9?w=0 shows that only serial is bumped up and freebsd removed from some condition.
utACK https://github.com/bitcoin/bitcoin/pull/8198/commits/0e209f9bf940ec2f6215885cf30deaa7355086e9
But: nobody reported this issue to us anyway. But: why not... I think it makes sense only if we have an issue for such "syncs".
-
fanquake commented at 4:41 AM on June 14, 2016: member
Yes I'm not sure why there is such a whitespace difference between the actual draft4 and the version available on gnu.org. I guess we could just include the important changes?
-
MarcoFalke commented at 8:15 AM on June 14, 2016: member
utACK 0e209f9
-
laanwj commented at 9:49 AM on June 14, 2016: member
But: nobody reported this issue to us anyway. But: why not... I think it makes sense only if we have an issue for such "syncs".
Agree, I don't think we should do this too often, especially not if the specific issue isn't reported to us.
Maybe it would makes sense to schedule an update of the
.m4s once per (major) release or so? And group them together in one pull. To include it in the per-release actions at the top of the release process?Apart from that, it's harmless (the actual diff is minimal and obvious), so utACK 0e209f9
- laanwj merged this on Jun 14, 2016
- laanwj closed this on Jun 14, 2016
- laanwj referenced this in commit 520161480e on Jun 14, 2016
- fanquake deleted the branch on Jun 22, 2016
- codablock referenced this in commit ec9867f6ea on Sep 16, 2017
- codablock referenced this in commit 0f27bc12ea on Sep 19, 2017
- codablock referenced this in commit 87da7723f1 on Dec 27, 2017
- codablock referenced this in commit 62852538e1 on Dec 28, 2017
- DrahtBot locked this on Sep 8, 2021