Do not set extra flags for unfiltered DNS seed results #8208

pull sipa wants to merge 1 commits into bitcoin:master from sipa:simplerservices changing 3 files +14 −12

sipa commented at 5:35 PM on June 15, 2016: member

Since #8083 and #7749 were both merged, any flag set in nRelevantServices would propagate to all CAddress results retrieved from the DNS seed, even if that DNS seed does not support filtering.

Fix this by making the name adaptation function also update the passed in flags.

Furthermore, move that from from DNSSeedData to net. Structs in chainparams should be data only.
Do not set extra flags for unfiltered DNS seed results bc0a895d81
MarcoFalke added the label P2P on Jun 15, 2016
gmaxwell commented at 9:17 PM on June 15, 2016: contributor

utACK
jonasschnelli commented at 6:52 AM on June 16, 2016: contributor

Thanks for fixing. utACK bc0a895d810107132651c8178e95a981b9f3ff74
laanwj commented at 8:44 AM on June 16, 2016: member

utACK https://github.com/bitcoin/bitcoin/pull/8208/commits/bc0a895d810107132651c8178e95a981b9f3ff74
laanwj merged this on Jun 16, 2016
laanwj closed this on Jun 16, 2016
laanwj referenced this in commit 0a64777b90 on Jun 16, 2016
codablock referenced this in commit 6255600b53 on Sep 16, 2017
codablock referenced this in commit e2d695683e on Sep 19, 2017
codablock referenced this in commit f7d7fd2a25 on Dec 27, 2017
codablock referenced this in commit 402eb55732 on Dec 28, 2017
andvgal referenced this in commit 79b6fbdd7d on Jan 6, 2019
furszy referenced this in commit 077ab3db70 on May 14, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Labels