Check if the macro PKG_PROG_PKG_CONFIG was expanded. #8242

1. 
   paveljanik commented at 5:03 pm on June 22, 2016: contributor

   If pkg-config is not installed, pkg-config’s pkg.m4 is not installed and thus the macro PKG_PROG_PKG_CONFIG is not expanded.

   Fixes #8228.

   With this change, the output without pkg-config installed is:

   0...
   1configure.ac:83: error: PKG_PROG_PKG_CONFIG macro not expanded, please install pkg-config
   2      If this token and others are legitimate, please use m4_pattern_allow.
   3      See the Autoconf documentation.
   4autoreconf: /usr/bin/autoconf failed with exit status: 1
   5bitcoin@linux-fx0x:~/bitcoin> 
   

2. Check if the macro PKG_PROG_PKG_CONFIG was expanded.

   If pkg-config is not installed, pkg-config's pkg.m4 is not installed
   and thus the macro PKG_PROG_PKG_CONFIG is not expanded.
   
   Fixes #8228.

   5d79863525
3. MarcoFalke added the label Build system on Jun 22, 2016
4. 
   fanquake commented at 2:03 am on June 23, 2016: member

   Tested on OS X with brew unlink pkg-config

   0./autogen.sh
   1configure.ac:83: error: PKG_PROG_PKG_CONFIG macro not expanded, please install pkg-config
   2      If this token and others are legitimate, please use m4_pattern_allow.
   3      See the Autoconf documentation.
   4autoreconf: /usr/local/Cellar/autoconf/2.69/bin/autoconf failed with exit status: 1
   

   0./configure
   1configure: error: pkg-config not found.
   

5. 
   theuni commented at 3:22 am on June 23, 2016: member

   pkg-config isn’t required for win32. The fact that it is in some places atm is a bug.
6. 
   luke-jr commented at 3:40 am on June 23, 2016: member

   While I generally support making as much as possible optional, I see no value in pkg-config (or pkgconf) being optional.
7. 
   theuni commented at 4:07 am on June 23, 2016: member

   @luke-jr reason being that it sometimes does more harm than good on Windows. But I suppose at this point we may be over-complicating things by trying to avoid the dependency.

   Maybe we’d be better off requiring it everywhere, and just not using it for Windows.

8. 
   paveljanik commented at 5:05 am on June 23, 2016: contributor

   @theuni I do not like requiring it where we do not need it. If we do not use it, it is more difficult to start compiling the source code (one more tool to install/workaround).

   If this change makes pkg-config unavailability an error, good, we can change it afterwards.

9. 
   luke-jr commented at 2:10 pm on June 23, 2016: member

   Or just require and it everywhere, including Windows… only pkgconf problems I’m aware of were fixed years ago.
10. 
    paveljanik commented at 2:25 pm on June 23, 2016: contributor

    @luke-jr Yes, this is the status-quo as of now.
11. 
    paveljanik commented at 7:47 pm on July 30, 2016: contributor

    Closing. Not needed now after #8314.
12. paveljanik closed this on Jul 30, 2016

    ---

13. DrahtBot locked this on Sep 8, 2021

Contributors
paveljanik fanquake theuni luke-jr

Labels
Build system