Include more information sources in BIP152 decoding implementation #8243

issue gmaxwell opened this issue on June 22, 2016
  1. gmaxwell commented at 7:25 PM on June 22, 2016: contributor

    Right now only the memory pool is considered. But often some of the missing transactions are in the orphan pool, and could simply be used.

    During reorgs, the to-be-disconnected blocks are not used, making BIP152 ineffective where it could instead be almost perfectly effective.

    Mempool conflicts are also a source of misses in BIP152 currently. A simple small memory of recent mempool conflicts (perhaps feerate sorted) would greatly increase the rate of blocks with no missing transactions.

    I'm just opening this issue so we don't forget to add these sources. More sources should probably be added before miss prediction, since they'll lead to better prediction of genuinely unknown transactions.

    (This should be tagged p2p enhancement)

  2. laanwj added the label Feature on Jun 23, 2016
  3. laanwj added the label P2P on Jun 23, 2016
  4. glozow commented at 2:05 PM on August 10, 2022: member

    AFAICT this has been implemented now! vExtraTxnForCompact contains replaced transactions, orphans, etc.

  5. glozow closed this on Aug 10, 2022

  6. bitcoin locked this on Aug 10, 2023
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-18 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me