Do not ask a UI question from bitcoind #8257

1. 
   sipa commented at 2:35 PM on June 24, 2016: member

   Fixes #8255 (we shouldn't ask to reindex when running without UI).

2. 
   instagibbs commented at 2:38 PM on June 24, 2016: member

   concept ACK. I was very confused when I thought it was a real question.

3. in src/ui_interface.h:None in e61773ce57 outdated

     75 | @@ -76,6 +76,9 @@ class CClientUIInterface
     76 |      /** Show message box. */
     77 |      boost::signals2::signal<bool (const std::string& message, const std::string& caption, unsigned int style), boost::signals2::last_value<bool> > ThreadSafeMessageBox;
     78 |  
     79 | +    /** Ask the user a question, if possible. Falls back to ThreadSafeMessageBox(noninteractive_message, caption, style) if not. */
     80 | +    boost::signals2::signal<bool (const std::string& message, const std::string& noninteractive_message, const std::string& caption, unsigned int style), boost::signals2::last_value<bool> > ThreadSafeQuestion;
   

   ---

   ---

   

   laanwj commented at 2:40 PM on June 24, 2016:

   Please document the return value in case the question could not be asked of the user.

   ---

   

   sipa commented at 2:45 PM on June 24, 2016:

   Fixed.

4. 
   laanwj commented at 2:43 PM on June 24, 2016: member

   Concept ACK utACK https://github.com/bitcoin/bitcoin/pull/8257/commits/1acf1db76fc3e07deb8f0f837934ea90383fedb5

5. Do not ask a UI question from bitcoind 1acf1db76f
6. sipa force-pushed on Jun 24, 2016
7. laanwj added the label GUI on Jun 24, 2016
8. laanwj added this to the milestone 0.13.0 on Jun 25, 2016
9. 
   jtimon commented at 3:42 PM on June 25, 2016: contributor

   utACK 1acf1db

10. 
    jonasschnelli commented at 7:47 PM on June 25, 2016: contributor

    utACK 1acf1db

11. 
    laanwj commented at 8:11 AM on June 28, 2016: member

    Tested ACK https://github.com/bitcoin/bitcoin/commit/1acf1db76fc3e07deb8f0f837934ea90383fedb5.

    $ src/bitcoind -datadir=/store/tmp/testbtc 
    : Load Error..
    Please restart with -reindex or -reindex-chainstate to recover.
    bitcoind: /home/orion/projects/bitcoin/bitcoin/src/scheduler.cpp:19: CScheduler::~CScheduler(): Assertion `nThreadsServicingQueue == 0' failed.
    Aborted (core dumped)
    

    The CScheduler assertion issue is unrelated (this is issue #6735).

    GUI correctly asks the question, also verified that Abort and OK give back the correct result.

12. laanwj merged this on Jun 28, 2016
13. laanwj closed this on Jun 28, 2016

    ---

14. laanwj referenced this in commit ff03c50c00 on Jun 28, 2016
15. zkbot referenced this in commit ec772897e7 on Mar 1, 2017
16. zkbot referenced this in commit c1cff6069f on Mar 2, 2017
17. codablock referenced this in commit 8b410d33f9 on Sep 7, 2017
18. UdjinM6 referenced this in commit 9707ca5cea on Sep 9, 2017
19. MarcoFalke locked this on Sep 8, 2021

Contributors

sipainstagibbslaanwjjtimonjonasschnelli

Milestone
0.13.0