Versionbits should have an ignore button #8266

issue gmaxwell opened this issue on June 26, 2016
  1. gmaxwell commented at 1:40 AM on June 26, 2016: contributor

    It should be possible to configure a node to ignore particular versionbit activations and not warn about them-- because they're not relevant to you.

    Config could be something like: vbaddignore=5:806400 # bit:height

    It should also be possible to preset ignores as network parameters.

    Testnet now has a testcase for this as there a long run of blocks with undefined bit 28 set.

    It'll be useful to have this in place ahead of the wallet making use of VB warnings in the future (e.g. hiding unconfirmed txn and delaying confirmation indicators when a warning is active).

  2. maflcko added the label Feature on Jun 26, 2016
  3. maflcko added the label Validation on Jun 26, 2016
  4. maflcko removed the label Validation on Jun 26, 2016
  5. dcousens commented at 3:05 AM on June 27, 2016: contributor

    Does height exactly correlate with the BIP9's starttime or is it a generic parameter to ignore only from a particular point in time?

  6. gmaxwell commented at 3:16 AM on June 27, 2016: contributor

    It must be either the lock-in time or activation time (I don't care which, they're the same but for the 2016 block offset). It would ignore only that particular use of the bit, if the same bit is recycled and used again, it should still warn.

    So it's more like a "not after" rather than a not before. Right now the bip9 logic warns forever once an unknown bit is activated. So this proposes the ability to ignore a specific activation event (which is a height/bit or blockhash/bit pair), but continue to warn on future activation events using that bit.

    This lets you look at it and go "oh, this is OP_CHECKSPATULAVERIFY, I don't care about that, won't impact my usage... ignore" but later when MULCHBABIES softfork happens on the same bit, you'll get warned again and be able to respond with a pitchfork.

  7. pinheadmz commented at 9:09 PM on March 3, 2023: member

    I think this issue can be closed since the warnings were removed in https://github.com/bitcoin/bitcoin/pull/15471

  8. adamjonas commented at 8:10 PM on March 9, 2023: member

    I think this issue can be closed since the warnings were removed in #15471

    Closing.

  9. adamjonas closed this on Mar 9, 2023

  10. bitcoin locked this on Mar 8, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me