[doc] Docs and copyright headers bump #8286

  30 | @@ -31,7 +31,8 @@ The `master` branch is regularly built and tested, but is not guaranteed to be
  31 |  completely stable. [Tags](https://github.com/bitcoin/bitcoin/tags) are created
  32 |  regularly to indicate new official, stable release versions of Bitcoin Core.
  33 |  
  34 | -The contribution workflow is described in [CONTRIBUTING.md](CONTRIBUTING.md).
  35 | +The contribution workflow is described in [CONTRIBUTING.md](CONTRIBUTING.md)
  36 | +and useful hints for developers can be found in [doc/developer-notes.md](doc/developer-notes.md)

paveljanik commented at 8:57 AM on July 1, 2016:

Missing dot at the end of sentence.

 105 |  #txconfirmtarget=n
 106 |  
 107 | +# Pay an optional transaction fee every time you send bitcoins.  Transactions with fees
 108 | +# are more likely than free transactions to be included in generated blocks, so may
 109 | +# be validated sooner.
 110 | +#paytxfee=0.00

roques commented at 4:21 PM on July 1, 2016:

The unit (BTC/kB) of paytxfee should be specified here, as it is in bitcoind -?. I also would completely remove the second sentence.

MarcoFalke commented at 4:31 PM on July 1, 2016:

Oh right. I was just moving the sentence.

A general rewrite should be preferred.

  99 | -            "to run zmq tests, see dependency info in /qa/README.md.")
 100 | -        ENABLE_ZMQ=0
 101 | +    except ImportError:
 102 | +        print("ERROR: \"import zmq\" failed. Set ENABLE_ZMQ=0 or "
 103 | +              "to run zmq tests, see dependency info in /qa/README.md.")
 104 | +        # ENABLE_ZMQ=0

fanquake commented at 3:06 AM on August 8, 2016:

Why not remove this line?

MarcoFalke commented at 5:26 AM on August 8, 2016:

Someone catching this exception and reading this line can just uncomment it, instead of looking up how to unset zmq...

 105 | +# Create transactions that have enough fees so they are likely to begin confirmation within n blocks.
 106 |  # This setting is over-ridden by the -paytxfee option.
 107 |  #txconfirmtarget=n
 108 |  
 109 | +# Pay a transaction fee every time you send bitcoins.
 110 | +#paytxfee=0.000x

jonasschnelli commented at 8:15 AM on August 8, 2016:

Maybe mention that this is per KB?

MarcoFalke commented at 8:25 AM on August 8, 2016:

All fees exposed via the user interface are BTC per kB (or mBTC per Byte). I don't think it adds value to mention it everywhere.

MarcoFalke commented at 8:27 AM on August 8, 2016:

But I agree, somehow this whole examples/bitcoin.conf file needs update. Though, someone should do it in a later pull, I guess.

   0 | @@ -1,5 +1,5 @@
   1 |  #!/usr/bin/env python3
   2 | -# Copyright (c) 2015 The Bitcoin Core developers
   3 | +# Copyright (c) 2015-2016 The Bitcoin Core developers

jonasschnelli commented at 8:17 AM on August 8, 2016:

Has this been changed in 2016? nm: I think so.