Moves code for header verification out of main, to consensus.
EDIT:
Partially replaces #7310, only for the header verification part.
Like in core_io.h we can separate the cpp files instead of using a single consensus.cpp.
Continues #8329
It’s analogous to #8329 but with the functions necessary for VerifyHeader().
Each PR contains more things than the previous one. I could make them independent for easier review instead of each one building on top of the previous, but that would more work. Or I can just close them. Only the first one seems to be getting any review anyway… On Jul 14, 2016 1:52 PM, “Jonas Schnelli” notifications@github.com wrote:
This PR contains identical commits then #8328 #8328 and #8329 #8329. Can you explain why there are multiple PRs? IMO opening a single small PR and trying to get this merge would be more efficient (and only open/PR further work when the first part has been merged).
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub #8337 (comment), or mute the thread https://github.com/notifications/unsubscribe/AA9jSkECkHcKe1bhOGYzTNkqWpxVKaa2ks5qViK9gaJpZM4JLak4 .
10@@ -11,7 +11,7 @@
11 #include "chainparams.h"
12 #include "checkpoints.h"
13 #include "checkqueue.h"
14-#include "consensus/consensus.h"
7@@ -8,6 +8,12 @@
8
9 #include <stdint.h>
10
11+/**
12+ * Maximum amount of time that a block timestamp is allowed to exceed the
13+ * current network-adjusted time before the block will be accepted.
14+ */
15+static const int64_t MAX_FUTURE_BLOCK_TIME = 2 * 60 * 60;
In commit “MOVEONLY: MAX_FUTURE_BLOCK_TIME to consensus/consensus.h”
Not sure if if it’s exactly right to make this a consensus constant, because even in the worst case if this is set inconsistently, consensus should eventually be reached when system clock times catch up. IIRC, this was the reasoning @morcos gave me for not defining this constant in consensus.h.