[mempool] Fix relaypriority calculation error #8357

pull maiiz wants to merge 1 commits into bitcoin:master from maiiz:maiiz-patch-1 changing 1 files +1 −1

maiiz commented at 7:04 AM on July 18, 2016: contributor

[mempool] Fix relaypriority calculation error

Fixes #8334
MarcoFalke renamed this:
~~Update coins.cpp~~
[Wallet] Fix relaypriority calculation error
on Jul 18, 2016
MarcoFalke added the label Wallet on Jul 18, 2016
maiiz commented at 7:06 AM on July 18, 2016: contributor

I‘m so sorry ! for this pull request, I try three times.
MarcoFalke commented at 7:08 AM on July 18, 2016: member

No worries. There is always bitcoin-core-dev on freenode. We are happy to help with git issues.
maiiz commented at 7:12 AM on July 18, 2016: contributor

@MarcoFalke thanks, and how can i delete the two closed pull request i created before?
laanwj commented at 7:15 AM on July 18, 2016: member

and how can i delete the two closed pull request i created before?

Only github admins can delete pull requests, but don't worry about them.
maiiz commented at 7:24 AM on July 18, 2016: contributor

@laanwj Thank you for your reply.
MarcoFalke commented at 11:13 AM on August 3, 2016: member
@maiiz You can still try to adjust the commit message locally (with git)
```
git clone $yourrepo
cd $yourrepo
git checkout maiiz-patch-1
git commit --amend
git push origin maiiz-patch-1 -f
```
maiiz force-pushed on Aug 29, 2016
maiiz commented at 7:14 AM on August 29, 2016: contributor

@MarcoFalke i change the commit message as you teached!
MarcoFalke commented at 7:32 AM on August 29, 2016: member

utACK 11d7cd5
luke-jr commented at 8:15 AM on September 10, 2016: member

utACK
luke-jr commented at 8:16 AM on September 10, 2016: member

... although this has nothing to do with the wallet? Commit message should probably be fixed.
MarcoFalke added the label Mempool on Sep 11, 2016
MarcoFalke removed the label Wallet on Sep 11, 2016
MarcoFalke renamed this:
~~[Wallet] Fix relaypriority calculation error~~
[CCoinsViewCache] Fix relaypriority calculation error
on Sep 11, 2016
MarcoFalke renamed this:
~~[CCoinsViewCache] Fix relaypriority calculation error~~
[mempool] Fix relaypriority calculation error
on Sep 11, 2016
maiiz commented at 2:11 AM on September 13, 2016: contributor
@luke-jr should i change the commit message again? change like this?
```
[wallet] Fix relaypriority calculation error -> [mempool] Fix relaypriority calculation error 
```
MarcoFalke commented at 10:20 AM on September 13, 2016: member

@maiiz Sorry for the confusion: I think the mempool, miner and wallet use this logic, but each have the code copied and this bug can only be found in one of the instances... You can remove the tag altogether from the commit message just to be safe.
maiiz force-pushed on Sep 20, 2016
Fix relaypriority calculation error 94a34a5d95
maiiz force-pushed on Sep 20, 2016
gmaxwell commented at 5:03 AM on September 27, 2016: contributor

utACK
MarcoFalke commented at 8:51 AM on September 27, 2016: member

utACK 94a34a5
laanwj merged this on Sep 27, 2016
laanwj closed this on Sep 27, 2016
laanwj referenced this in commit e9d5f6fec8 on Sep 27, 2016
laanwj referenced this in commit 000b663e9c on Oct 25, 2016
laanwj referenced this in commit ce0d817b9b on Oct 27, 2016
codablock referenced this in commit b141484398 on Sep 19, 2017
codablock referenced this in commit 9cc76af50d on Sep 27, 2017
codablock referenced this in commit 3fe7c41384 on Oct 12, 2017
schinzelh referenced this in commit 5c62fedd4e on Oct 23, 2017
codablock referenced this in commit a8662eff35 on Oct 23, 2017
codablock referenced this in commit 8f6b45644d on Oct 26, 2017
codablock referenced this in commit b224c02090 on Jan 12, 2018
andvgal referenced this in commit 5fe9ecf257 on Jan 6, 2019
maiiz deleted the branch on Dec 16, 2019
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#8334 relaypriority calculation error