[qa]: enable rpcbind_test #8400

pull rodentrabies wants to merge 2 commits into bitcoin:master from rodentrabies:rpcbind-test changing 3 files +102 −129

rodentrabies commented at 10:38 PM on July 24, 2016: contributor

Added parsing for '<host>:<port>' arguments to rpc_url(), as it was required for this test to work. Also, changed username and password that were passed to get_rpc_proxy() in run_allowip_test() to hardcoded (default) ones via call to rpc_url().
[qa]: add parsing for '<host>:<port>' argument form to rpc_url() 0ff4375c93
[qa]: enable rpcbind_test 9bbb414b80
jonasschnelli added the label Tests on Jul 25, 2016
laanwj commented at 3:55 PM on July 25, 2016: member

Thanks! utACK https://github.com/bitcoin/bitcoin/pull/8400/commits/9bbb414b800cf71f93f15d2cb5d4cf32c72294e6
laanwj assigned MarcoFalke on Jul 26, 2016
rodentrabies commented at 8:54 PM on July 26, 2016: contributor

For #8351
MarcoFalke commented at 1:41 PM on July 28, 2016: member

Thank you for fixing the issue!

Concept ACK. Will take a closer look in the coming days...
MarcoFalke merged this on Jul 31, 2016
MarcoFalke closed this on Jul 31, 2016
MarcoFalke referenced this in commit cf2cecb187 on Jul 31, 2016

in qa/rpc-tests/rpcbind_test.py:None in 9bbb414b80

   4 | @@ -5,143 +5,108 @@
   5 |  
   6 |  # Test for -rpcbind, as well as -rpcallowip and -rpcconnect
   7 |  
   8 | -# TODO extend this test from the test framework (like all other tests)
   9 | -
  10 |  import tempfile
  11 |  import traceback

MarcoFalke commented at 3:23 PM on July 31, 2016:

Nit: You can remove the imports as well.

luke-jr referenced this in commit e111904a76 on Sep 21, 2016
luke-jr referenced this in commit bea02dc3b6 on Sep 21, 2016
codablock referenced this in commit 080fbd7b0a on Sep 19, 2017
codablock referenced this in commit 6c62afac71 on Dec 29, 2017
codablock referenced this in commit 8c76eb7394 on Jan 8, 2018
andvgal referenced this in commit f0e3725c46 on Jan 6, 2019
zkbot referenced this in commit 025bd44543 on Nov 21, 2020
zkbot referenced this in commit 7a0a268054 on Dec 2, 2020
zkbot referenced this in commit c8896f9907 on Dec 2, 2020
rodentrabies deleted the branch on Mar 15, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels