libconsensus: Expose a flag for BIP112 #8412

1. 
   jtimon commented at 9:13 PM on July 27, 2016: contributor

   We added the segwit one, but we forgot CHECKSEQUENCEVERIFY. @laanwj this needs backport to 0.13, right? In fact, I'm thinking that this should have been included in 0.12.1...

   Ping @sipa @TheBlueMatt

   Bikeshedding: I removed "FLAGS_" in this one and added "_BIP112" at the end instead because I believe it's more useful. I'm happy to change the name of the flag.

   EDIT: Note that the bit positions have to correspond with those in the flags for scripts in script/interpreter.h.

2. 
   btcdrak commented at 9:47 PM on July 27, 2016: contributor

   Why arent you following the status quo for naming?

3. 
   jtimon commented at 10:15 PM on July 27, 2016: contributor

   I'm saying it, I thought adding bip112 at the end would be more useful, changing back already... Or are you complaining only about the missing "FLAGS_"?

4. libconsensus: Expose a flag for BIP112

   We added the segwit one, but we forgot CHECKSEQUENCEVERIFY

   d12b732ac2
5. jtimon force-pushed on Jul 27, 2016
6. 
   jtimon commented at 10:24 PM on July 27, 2016: contributor

   Updated following the style and without adding BIP112 at the end.

7. jonasschnelli added the label Consensus on Jul 28, 2016
8. jonasschnelli added the label Refactoring on Jul 28, 2016
9. 
   btcdrak commented at 9:07 AM on July 28, 2016: contributor

   ACK d12b732

10. jonasschnelli added the label Needs backport on Jul 28, 2016
11. jonasschnelli removed the label Refactoring on Jul 28, 2016
12. jonasschnelli added this to the milestone 0.13.0 on Jul 28, 2016
13. 
    sipa commented at 7:04 PM on July 28, 2016: member

    utACK d12b732

14. 
    jonasschnelli commented at 7:05 PM on July 28, 2016: contributor

    utACK d12b732ac287a1ed7543481b79801c9afc333b7f

15. 
    NicolasDorier commented at 7:25 PM on July 28, 2016: contributor

    utACK d12b732ac287a1ed7543481b79801c9afc333b7f

16. sipa merged this on Jul 28, 2016
17. sipa closed this on Jul 28, 2016

    ---

18. sipa referenced this in commit ad087638ee on Jul 28, 2016
19. sipa referenced this in commit 8360d5b37d on Jul 28, 2016
20. MarcoFalke removed the label Needs backport on Jul 31, 2016
21. MarcoFalke added the label Needs backport on Jul 31, 2016
22. MarcoFalke removed this from the milestone 0.13.0 on Jul 31, 2016
23. MarcoFalke added this to the milestone 0.12.0 on Jul 31, 2016
24. laanwj added this to the milestone 0.12.2 on Sep 26, 2016
25. laanwj removed this from the milestone 0.12.0 on Sep 26, 2016
26. codablock referenced this in commit f710c2ea99 on Sep 19, 2017
27. codablock referenced this in commit 7b411f5bb0 on Dec 29, 2017
28. codablock referenced this in commit 2e4e12f4a9 on Jan 8, 2018
29. fanquake removed the label Needs backport on Mar 7, 2018
30. andvgal referenced this in commit df30e6f0d1 on Jan 6, 2019
31. MarcoFalke locked this on Sep 8, 2021

Contributors

jtimonbtcdraksipajonasschnelliNicolasDorier

Milestone
0.12.branch