Avoid logging notfound messages as unknown "command".
Alternative to #8403.
net: Ignore `notfound` P2P messages #8427
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2016_07_notfound changing 1 files +5 −0-
laanwj commented at 3:43 PM on July 29, 2016: member
- laanwj added the label P2P on Jul 29, 2016
-
net: Ignore `notfound` P2P messages 5c9e49d12c
- laanwj force-pushed on Jul 29, 2016
-
sipa commented at 7:42 PM on July 29, 2016: member
utACK 5c9e49d12c931f9c7ddaac0144739dcd7263e554
-
paveljanik commented at 7:45 PM on July 29, 2016: contributor
-
NicolasDorier commented at 8:09 PM on July 29, 2016: contributor
utACK 5c9e49d12c931f9c7ddaac0144739dcd7263e554
-
fanquake commented at 11:57 PM on July 29, 2016: member
utACK 5c9e49d
- sipa merged this on Jul 30, 2016
- sipa closed this on Jul 30, 2016
- sipa referenced this in commit ebefe7a00b on Jul 30, 2016
-
rebroad commented at 7:02 AM on July 31, 2016: contributor
all this influence I have on bitcoin yet never make it into the commit logs!
-
rebroad commented at 7:39 AM on July 31, 2016: contributor
Ok, I have to ask this. Why are these messages generated if they are ignored?
-
laanwj commented at 7:09 AM on August 1, 2016: member
all this influence I have on bitcoin yet never make it into the commit logs!
If you had changed your PR after @sipa and my suggestion I'd just have merged that one. I didn't want to have this linger for weeks.
Ok, I have to ask this. Why are these messages generated if they are ignored?
That's a good question. From what I remember, some SPV clients pay attention to the message. Maybe you can find the PR introducing the message in history.
- luke-jr referenced this in commit 69d1cd202d on Sep 21, 2016
- zkbot referenced this in commit efc771804e on Oct 22, 2016
- zkbot referenced this in commit f808be7546 on Oct 22, 2016
- zkbot referenced this in commit e3c8e88e9b on Oct 22, 2016
- codablock referenced this in commit 8ef2808abc on Sep 19, 2017
- codablock referenced this in commit f5a6ce20bb on Dec 29, 2017
- codablock referenced this in commit 7c1c9d0ea6 on Jan 8, 2018
- lateminer referenced this in commit 81d9a0d657 on Oct 24, 2018
- andvgal referenced this in commit 681b2ce7b0 on Jan 6, 2019
- DrahtBot locked this on Sep 8, 2021
