document return value of networkhashps for getmininginfo RPC endpoint #8461

pull jlopp wants to merge 1 commits into bitcoin:master from jlopp:rpcMiningHelp changing 1 files +3 −2

jlopp commented at 9:36 PM on August 4, 2016: contributor

It looks like this value isn't documented in the RPC help. If it would be helpful, we could be even more specific and mention that it uses the default trailing 120 blocks parameter to calculate the hashrate.

paveljanik commented at 7:00 AM on August 5, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/8461/commits/205eb350fd312ee0cf8dde9b0db0418799d2fbd9

As you are touching the helptext, can you please align "errors" and "chain" helptexts by adding two spaces before "(string)"?

  "errors": "..."          (string) Current errors
  "networkhashps": nnn,      (numeric) The network hashes per second
  "pooledtx": n              (numeric) The size of the mem pool
  "testnet": true|false      (boolean) If using testnet or not
  "chain": "xxxx",         (string) current network name as defined in BIP70 (main, test, regtest)

jonasschnelli added the label Docs and Output on Aug 5, 2016
jonasschnelli commented at 7:39 AM on August 5, 2016: contributor

ACK https://github.com/bitcoin/bitcoin/pull/8461/commits/205eb350fd312ee0cf8dde9b0db0418799d2fbd9 agree with @paveljanik about the PR related nits.
document return value of networkhashps for getmininginfo RPC endpoint 65f4532f13
jlopp force-pushed on Aug 5, 2016
MarcoFalke commented at 8:05 AM on August 5, 2016: member

ACK 65f4532
jlopp commented at 8:05 AM on August 5, 2016: contributor

Updated to align "chain" and "errors" output with rest of help text.
paveljanik commented at 8:11 AM on August 5, 2016: contributor

Thank you!

ACK https://github.com/bitcoin/bitcoin/commit/65f4532f13a89cacc4909072601d71ee7ebae5c5
btcdrak commented at 10:52 AM on August 5, 2016: contributor

ACK 65f4532
fanquake commented at 8:03 AM on August 6, 2016: member

ACK 65f4532
laanwj merged this on Aug 19, 2016
laanwj closed this on Aug 19, 2016
laanwj referenced this in commit f4e777819c on Aug 19, 2016
MarcoFalke added the label Needs backport on Aug 19, 2016
MarcoFalke removed the label Needs backport on Aug 19, 2016
luke-jr commented at 8:56 AM on September 10, 2016: member

Backport needed, I guess. (all the way back to 0.9.x, but we don't maintain that far back)
MarcoFalke commented at 10:52 AM on September 11, 2016: member

@luke-jr According to current https://bitcoincore.org/en/lifecycle/ 0.11 only receives critical security fixes and this is only a documentation fix. (Though, I am not against backports for 0.12 and 0.13)
luke-jr referenced this in commit b17a3f9e5a on Sep 21, 2016
codablock referenced this in commit 967b1e4bb3 on Sep 19, 2017
codablock referenced this in commit 8aabc822df on Dec 29, 2017
codablock referenced this in commit 5bf3dadcb6 on Jan 8, 2018
andvgal referenced this in commit 6666a38c51 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels