[qt] Remove Priority from coincontrol dialog #8463

MarcoFalke commented at 5:04 PM on August 5, 2016: member

Is anyone still using this? Even though the information is only shown for "experts", I don't think it adds value.

Please note that you could still send low fee/high prio transactions via the command line switch, but the GUI will no longer print the priority string: screenshot from 2016-08-05 19-01-35

MarcoFalke added the label GUI on Aug 5, 2016

luke-jr commented at 8:51 PM on August 5, 2016: member

Yes, I am still using it. In theory the date might be enough, but it's easier to tell at a glance from "low"/"medium"/"high" which are older.

MarcoFalke commented at 8:33 AM on August 8, 2016: member

"low"/"medium"/"high" which are older.

Please note there is also a column indicating the number of confirmations (not shown in my screenshot). So if you are interested in the ago of the coins, this should be sufficient.

Also, looking at the Amount- and Confirmations-column should be sufficient to do priority estimation on the envelope/in your head, keeping in mind "medium" means one coinday (or 144 coinconfirmations) per 250kB. (Exact numbers are irrelevant, anyway)

jonasschnelli commented at 8:44 AM on August 8, 2016: contributor

No strong opinion. But I guess priority will become more and more a relict. Concept ACK.

MarcoFalke commented at 8:51 AM on August 8, 2016: member

a relict

If you look at the tooltips right now, it implies the opposite: https://github.com/bitcoin/bitcoin/pull/8463/files#diff-409074603e1373817f983557bebc15daL653

jonasschnelli commented at 9:00 AM on August 8, 2016: contributor

@MarcoFalke: With...

But I guess priority will become more and more a relict.

... I meant that "priority" as a property of the bitcoin network becomes more and more a relict, something no longer has a significant value or use.

I agree, we should remove it or at least reduce its significant (red label, etc.).

sipa commented at 5:37 AM on August 10, 2016: member

Concept ACK

laanwj commented at 10:51 AM on August 17, 2016: member

Concept ACK

jonasschnelli commented at 9:04 AM on August 24, 2016: contributor

Tested a bit. There is an issue with the column auto-stretch (or similar issue). Check the screenshot: <img width="1214" alt="bildschirmfoto 2016-08-24 um 11 03 45" src="https://cloud.githubusercontent.com/assets/178464/17924800/87e75ba8-69ea-11e6-9988-00149628c5c1.png">

in src/qt/coincontroldialog.cpp:None in fa2dbb2327 outdated

 125 | @@ -129,11 +126,9 @@ CoinControlDialog::CoinControlDialog(const PlatformStyle *platformStyle, QWidget
 126 |      ui->treeWidget->setColumnWidth(COLUMN_ADDRESS, 290);
 127 |      ui->treeWidget->setColumnWidth(COLUMN_DATE, 110);
 128 |      ui->treeWidget->setColumnWidth(COLUMN_CONFIRMATIONS, 100);
 129 | -    ui->treeWidget->setColumnWidth(COLUMN_PRIORITY, 100);

jonasschnelli commented at 9:12 AM on August 24, 2016:

I think you need to distribute the removed 100px to some other columns.

MarcoFalke commented at 9:27 AM on August 24, 2016:

Thanks for the help!

With resetguisettings I am getting this now:

screenshot from 2016-08-24 11-26-12

jonasschnelli commented at 9:36 AM on August 24, 2016: contributor

Looks better. Tested ACK fa135881374c63bf27c106ffd3c5d79c084da48f Needs squashing.

[qt] Remove Priority from coincontrol dialog fa8dd785a2

MarcoFalke force-pushed on Aug 24, 2016

MarcoFalke commented at 9:43 AM on August 24, 2016: member

Done fa8dd78

jonasschnelli merged this on Aug 24, 2016

jonasschnelli closed this on Aug 24, 2016

jonasschnelli referenced this in commit 62a5a8a018 on Aug 24, 2016

MarcoFalke deleted the branch on Aug 24, 2016

codablock referenced this in commit 12dd80aa75 on Sep 7, 2017

UdjinM6 referenced this in commit 9707ca5cea on Sep 9, 2017

MarcoFalke locked this on Sep 8, 2021