Remove unused variables #8590

This removes the remaining unused variables outside of src/test.

ACK https://github.com/bitcoin/bitcoin/pull/8590/commits/fa6dc9f0e5eac8ec473b63adfd43635005778f46

ACK fa6dc9f

Thanks, utACK

Just out of curiosity: what did you use to find these?

@laanwj I was looking into cppcheck and cpplint the last days. It was trivial to set up. According to the tools, those are the last unused variables.

Also, they found a ton of unused functions, but I couldn't find anything that deserves attention. E.g. DeleteAuthCookie is unused, but there is no point in removing the code. Almost all unused functions potentially turn out to be useful in the future.

Finally, cppcheck returned some errors and warnings but my knowledge of cpp is too low. So they could very well be false positives.

<sub>It would probably be fun to set up a GitHub bot account which scans each pull request and then spams all the code nits in the appropriate lines in the code...

@laanwj I was looking into cppcheck and cpplint the last days. It was trivial to set up. According to the tools, those are the last unused variables.

Thanks, I'll check them out. I think I've had cppcheck installed at some point, but kind of forgot about it.

E.g. DeleteAuthCookie is unused, but there is no point in removing the code.

Yes sometimes a half of a [create,remove] pair that really belongs together is unused, this is one example. More an indication of 'this needs tests' than 'this code needs to be removed'.

utACK fa6dc9f