Fix some locks #8606

pull sipa wants to merge 1 commits into bitcoin:master from sipa:lockfix changing 1 files +21 −15
  1. sipa commented at 7:09 PM on August 26, 2016: member

    This makes sure that cs_filter is never held while taking cs_main or CNode::cs_vSend.

    This should fix #8599.

  2. Fix some locks
    This makes sure that cs_filter is never held while taking cs_main
    or CNode::cs_vSend.
    144ed76ea0
  3. sipa force-pushed on Aug 26, 2016
  4. luke-jr commented at 2:32 AM on August 27, 2016: member

    utACK

  5. sipa commented at 6:47 AM on August 27, 2016: member

    I believe this bug was introduced in 0.13.0.

  6. jonasschnelli added the label Needs backport on Aug 27, 2016
  7. MarcoFalke added this to the milestone 0.13.1 on Aug 27, 2016
  8. MarcoFalke added the label Refactoring on Aug 27, 2016
  9. MarcoFalke added the label Resource usage on Aug 27, 2016
  10. MarcoFalke commented at 9:15 AM on August 27, 2016: member

    utACK 144ed76ea0b38b7c21b224501964f8a2c65c4bb6

  11. sipa commented at 4:43 PM on August 27, 2016: member

    Feel like testing whether this fixes your issue #8599, @jonasschnelli ?

  12. jonasschnelli commented at 7:14 AM on September 1, 2016: contributor

    I just ran again into #8599... Added this PR on top of current master and re-started the node... will report.

  13. jonasschnelli commented at 6:23 AM on September 7, 2016: contributor

    My node having the issue #8599 did run without deadlock assertion-exit the last 7 days. Testes ACK https://github.com/bitcoin/bitcoin/pull/8606/commits/144ed76ea0b38b7c21b224501964f8a2c65c4bb6

  14. sipa merged this on Sep 7, 2016
  15. sipa closed this on Sep 7, 2016

  16. sipa referenced this in commit e2a1a1ee89 on Sep 7, 2016
  17. MarcoFalke removed the label Needs backport on Sep 9, 2016
  18. codablock referenced this in commit 4cdbaf54a3 on Sep 19, 2017
  19. codablock referenced this in commit 000516ea04 on Jan 9, 2018
  20. codablock referenced this in commit f7e9bc613a on Jan 9, 2018
  21. andvgal referenced this in commit 4051977f6c on Jan 6, 2019
  22. random-zebra referenced this in commit 777638e7bc on Aug 27, 2020
  23. LarryRuane referenced this in commit 23d0ab8a31 on Feb 24, 2021
  24. LarryRuane referenced this in commit 451600b9a6 on Apr 1, 2021
  25. zkbot referenced this in commit 1b5f17c900 on Apr 1, 2021
  26. zkbot referenced this in commit 80e66e7daa on Apr 2, 2021
  27. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me