Fix compiler warnings #8619

pull rebroad wants to merge 1 commits into bitcoin:master from rebroad:FixCompilerWarnings changing 3 files +3 −3

rebroad commented at 4:25 AM on August 28, 2016: contributor

No description provided.
Fix compiler warnings 6ef3bd1216
fanquake commented at 4:28 AM on August 28, 2016: member

These should be submitted to the bitcoin-core leveldb repo.
MarcoFalke added the label Upstream on Aug 28, 2016
MarcoFalke commented at 5:36 AM on August 28, 2016: member

Right, we can not merge this, as it would "overwrite" the subtree. Please submit upstream: https://github.com/google/leveldb
MarcoFalke closed this on Aug 28, 2016
rebroad commented at 3:34 AM on August 29, 2016: contributor

ah, ok, thanks. have raised https://github.com/bitcoin-core/leveldb/pull/15
rebroad commented at 3:37 AM on August 29, 2016: contributor

I'm a little confused though as it does seem that these files are in bitcoin also.. should they be in both projects? how are they kept in sync?
sipa commented at 7:34 AM on August 29, 2016: member

git subtree.
rebroad commented at 3:28 AM on September 25, 2016: contributor

@sipa I'm still seeing these errors when compiling bitcoin, even though I've PRed the leveldb... how do I stop the old versions of these files from being put in the directory structure please?
sipa commented at 4:32 AM on September 25, 2016: member

It's just a copy of the tree. If you want the same changes to show up to test with, just make the sake changes in the subtree.
DrahtBot locked this on Sep 8, 2021

Contributors

Labels