rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST #8638

pull djpnewton wants to merge 1 commits into bitcoin:master from djpnewton:patch-2 changing 3 files +16 −12

djpnewton commented at 11:54 PM on August 31, 2016: contributor

No description provided.
fanquake added the label RPC/REST/ZMQ on Sep 1, 2016

fanquake commented at 12:20 AM on September 1, 2016: member

The rest.py test is failing. Travis output:

rest.py:
Initializing test directory /tmp/testcuky3r1q/27
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
start_node: bitcoind started, waiting for RPC to come up
start_node: RPC succesfully started
Mining blocks...
Assertion failed: 400 != 500
Stopping nodes
Not cleaning up dir /tmp/testcuky3r1q/27
Failed
stderr:
   File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/test_framework.py", line 150, in main
    self.run_test()
  File "/home/travis/build/bitcoin/bitcoin/build/../qa/rpc-tests/rest.py", line 182, in run_test
    assert_equal(response.status, 500) #must be a 500 because we send a invalid json request
  File "/home/travis/build/bitcoin/bitcoin/qa/rpc-tests/test_framework/util.py", line 504, in assert_equal
    raise AssertionError("%s != %s"%(str(thing1),str(thing2)))
Pass: False, Duration: 8 s

djpnewton force-pushed on Sep 1, 2016
djpnewton commented at 2:40 AM on September 1, 2016: contributor

thanks, updated now
dcousens commented at 3:16 AM on September 1, 2016: contributor

concept ACK
jonasschnelli commented at 6:39 AM on September 1, 2016: contributor

Concept ACK. It's a tiny API change and maybe adding a short passage to the release notes could make sense.
dcousens commented at 6:54 AM on September 1, 2016: contributor

@jonasschnelli especially if people were checking the error codes that came back
rest.cpp: change HTTP_INTERNAL_SERVER_ERROR to HTTP_BAD_REQUEST f012a857f5
djpnewton force-pushed on Sep 1, 2016
djpnewton commented at 10:14 AM on September 1, 2016: contributor

I added a line to the release notes.

..initially it seemed like such a simple change at the time =)
laanwj commented at 12:00 PM on September 1, 2016: member

Changing APIs is always difficult (because it's partially a social problem), but the new codes make more sense, thanks for sticking with it. utACK https://github.com/bitcoin/bitcoin/pull/8638/commits/f012a857f5e9b3bdd11a64dd0c16b4c805076594
jgarzik commented at 12:41 PM on September 1, 2016: contributor

ut ACK
laanwj merged this on Sep 1, 2016
laanwj closed this on Sep 1, 2016
laanwj referenced this in commit f061415d12 on Sep 1, 2016
codablock referenced this in commit 89a59543f4 on Sep 19, 2017
codablock referenced this in commit 44942b8040 on Jan 9, 2018
codablock referenced this in commit bc91f34da6 on Jan 9, 2018
andvgal referenced this in commit d31b1b6d02 on Jan 6, 2019
DrahtBot locked this on Sep 8, 2021

Contributors

Labels