Remove unused Qt 4.6 patch. #8645

pull droark wants to merge 1 commits into bitcoin:master from droark:master changing 1 files +0 −10

droark commented at 12:25 AM on September 2, 2016: contributor

According to #8639 and #8640, Qt 4.6 is no longer supported by Core. There's a zombie Qt patch that doesn't seem to be used or referenced anywhere. So, I've removed it.

I have a related question for @theuni or anybody else who can answer. What is the oldest supported version of Qt 5? There's a small bit of code I'd like to clean up. The exact coding method depends on which versions of Qt are supported.

Thanks.

Remove unused Qt 4.6 patch.

Core no longer supports Qt 4. Therefore, the STL fix patch isn't needed.

38acbf83e1

fanquake added the label Build system on Sep 2, 2016
fanquake commented at 1:33 AM on September 2, 2016: member

ACK https://github.com/bitcoin/bitcoin/pull/8645/commits/38acbf83e1aa652f7af917efc31a035999a98af3
laanwj commented at 1:23 PM on September 6, 2016: member

trivial ACK 38acbf8

What is the oldest supported version of Qt 5?

I'm not sure it's the time to start deprecating versions of Qt 5 yet.
laanwj merged this on Sep 6, 2016
laanwj closed this on Sep 6, 2016
laanwj referenced this in commit 8ea44405e7 on Sep 6, 2016
droark commented at 7:43 AM on September 7, 2016: contributor

Thanks. I have no real horse in the race. I mean, sure, I'd prefer to simplify things and go Qt5-only, but if people are still using Qt4, no worries.
codablock referenced this in commit 8d52d3c52b on Sep 19, 2017
codablock referenced this in commit 0f55d34e6f on Jan 9, 2018
codablock referenced this in commit 2189570911 on Jan 9, 2018
MarcoFalke locked this on Sep 8, 2021

Contributors

Labels