Fix SIGHASH_SINGLE bug in test_framework SignatureHash #8667

pull jl2012 wants to merge 1 commits into bitcoin:master from jl2012:patch-16 changing 1 files +1 −1

jl2012 commented at 4:50 pm on September 5, 2016: contributor

The value for “other” inputs should be -1 (0xffffffffffffffff) instead of 0

Fix SIGHASH_SINGLE bug in test_framework SignatureHash

The value for "other" inputs should be -1 (0xffffffffffffffff) instead of 0

2f2548d5e0

sipa commented at 4:51 pm on September 5, 2016: member

Any unit tests in which this is exposed?
jl2012 commented at 5:14 pm on September 5, 2016: contributor

@sipa: yes, the Bare_137_CHECKSIG_random_flag in #8654
fanquake added the label Tests on Sep 5, 2016
sdaftuar commented at 0:02 am on September 6, 2016: member

utACK
laanwj commented at 1:10 pm on September 6, 2016: member

Shouldn’t this affect passing/non-passing of the test? Or is this part of the framework unused?
sipa commented at 1:16 pm on September 6, 2016: member

@laanwj It is unused until the introduction of the test in #8654 (which needs to pass a -1 explicitly for now).
Christewart commented at 2:16 pm on September 6, 2016: member

utACK
fanquake commented at 3:16 am on September 9, 2016: member

utACK 2f2548d
MarcoFalke commented at 9:19 pm on September 9, 2016: member

Link to upstream: https://github.com/petertodd/python-bitcoinlib/blob/d4f45f9d6c5f7f455e0f94d69357f84a08579bba/bitcoin/core/script.py#L885
MarcoFalke merged this on Sep 9, 2016
MarcoFalke closed this on Sep 9, 2016
MarcoFalke referenced this in commit 2a0836f6d5 on Sep 9, 2016
luke-jr referenced this in commit 6b07362b37 on Sep 21, 2016
codablock referenced this in commit 5cdedb2d96 on Sep 19, 2017
codablock referenced this in commit ce520f1614 on Jan 9, 2018
codablock referenced this in commit 85c0aabc11 on Jan 9, 2018
andvgal referenced this in commit c0cae10dfd on Jan 6, 2019
MarcoFalke locked this on Sep 8, 2021

Contributors
jl2012 sipa sdaftuar laanwj Christewart fanquake MarcoFalke

Labels
Tests