Add missing copyright headers #8676

pull isle2983 wants to merge 1 commits into bitcoin:master from isle2983:missing-copyright changing 9 files +28 −0
  1. isle2983 commented at 2:16 AM on September 7, 2016: contributor

    Adds 'The Bitcoin Core developers' copyright headers in 12 source files. <start_year>-<end_year> is as per the history obtained from 'git log'.

    The users to have touched them in the past are listed below. This was last discussed in pull request #7300:

    In that discussion I can see perma-ACKs from @MarcoFalke, @gavinandresen and @laanwj.

    So that leaves ACKs needed from: @sipa @jgarzik @luke-jr @theuni @ChoHag @calebogden @mrbandrews @casey @mitchellcash @brandondahler Phillip Kaufmann

    Broken down by file:

    contrib/devtools/optimize-pngs.py (@MarcoFalke, @jonasschnelli, @laanwj) contrib/devtools/security-check.py (@ChoHag, @laanwj, @theuni, @calebogden) contrib/devtools/test-security-check.py (@ChoHag, @laanwj) contrib/qt_translations.py (@gavinandresen) contrib/seeds/makeseeds.py (@laanwj, @sipa, @gavinandresen) contrib/spendfrom/setup.py (@gavinandresen) contrib/spendfrom/spendfrom.py (@gavinandresen) contrib/testgen/base58.py (@laanwj) contrib/testgen/gen_base58_test_vectors.py (@laanwj) contrib/zmq/zmq_sub.py (@jonasschnelli, @jgarzik) qa/rpc-tests/test_framework/blockstore.py (@mrbandrews, @MarcoFalke, @casey, @jonasschnelli) share/qt/extract_strings_qt.py (@ChoHag, @mitchellcash, @laanwj, @luke-jr, @brandondahler, Phillip Kaufmann, @theuni)

  2. fanquake added the label Docs and Output on Sep 7, 2016
  3. casey commented at 2:37 AM on September 7, 2016: contributor

    Ack from me

  4. brandondahler commented at 2:46 AM on September 7, 2016: contributor

    permanent ACK on all code I contribute to this repository having the preferred copyright of the project

  5. sipa commented at 6:03 AM on September 7, 2016: member

    ack from me

  6. jonasschnelli commented at 6:20 AM on September 7, 2016: contributor

    ACK

  7. fanquake commented at 8:07 AM on September 7, 2016: member

    ACK 2229ffa

  8. mrbandrews commented at 2:34 PM on September 7, 2016: contributor

    ack

  9. theuni commented at 4:20 PM on September 7, 2016: member

    ACK 2229ffa5e2b8e38cd962c02e2fc892e0c925675b

  10. MarcoFalke commented at 5:24 PM on September 7, 2016: member

    utACK 2229ffa5e2b8e38cd962c02e2fc892e0c925675b

    Could make sense to explicitly add a section to https://github.com/bitcoin/bitcoin/blob/master/CONTRIBUTING.md#contributing-to-bitcoin-core that says that every contribution must be MIT licensed by its author prior to creating a pull request.

  11. binflyingup commented at 1:43 AM on September 8, 2016: none

    ACK 2229ffa

  12. calebogden commented at 11:21 PM on September 8, 2016: none

    ACK 2229ffa5e2b8e38cd962c02e2fc892e0c925675b

  13. isle2983 commented at 12:43 AM on September 9, 2016: contributor

    Thanks everyone!

    We have ACK quorum on:

    contrib/devtools/optimize-pngs.py contrib/qt_translations.py contrib/seeds/makeseeds.py contrib/spendfrom/setup.py contrib/spendfrom/spendfrom.py contrib/testgen/base58.py contrib/testgen/gen_base58_test_vectors.py qa/rpc-tests/test_framework/blockstore.py

    Still waiting on:

    contrib/zmq/zmq_sub.py (@jgarzik) contrib/devtools/test-security-check.py (@ChoHag) contrib/devtools/security-check.py (@ChoHag) share/qt/extract_strings_qt.py (@ChoHag, @mitchellcash, @luke-jr, Phillip Kaufmann)

    I will give it a couple more days and then split the remaining files into a different PR so the ACKed ones can go in.

  14. achow101 commented at 2:27 AM on September 9, 2016: member

    Add the copyright to https://github.com/bitcoin/bitcoin/blob/master/contrib/gitian-build.sh please. I'll ACK it.

  15. isle2983 force-pushed on Sep 9, 2016
  16. isle2983 commented at 2:49 AM on September 9, 2016: contributor

    @achow101 copyright headers gitian-buiild.sh added in dffe727b259d0cc564e86aa1c33e7285e0f8c5b0

    ...which reminds me that I should do another PR for *.sh files.

  18. luke-jr commented at 10:02 AM on September 10, 2016: member

    ACK

  19. [copyright] Add missing copyright headers 783e930e68
  20. isle2983 force-pushed on Sep 11, 2016
  21. isle2983 force-pushed on Sep 11, 2016
  22. isle2983 commented at 9:54 PM on September 11, 2016: contributor

    783e930e68a312bc7654d833053cceead18dd688 drops the addition of the MIT headers in these files due to missing ACKs listed here:

    contrib/zmq/zmq_sub.py (@jgarzik) contrib/devtools/test-security-check.py (@ChoHag) contrib/devtools/security-check.py (@ChoHag) share/qt/extract_strings_qt.py (@ChoHag, Phillip Kaufmann)

    I will re-submit those as different PRs. @achow101 still owes the ACK promised above for gitian-build.sh. Assuming that comes, I submit that this PR is ready given the ACKs in #7300 and the present thread above.

    To recap, those were:

    contrib/devtools/optimize-pngs.py (@MarcoFalke, @jonasschnelli, @laanwj) contrib/gitian-build.sh (@achow101) contrib/qt_translations.py (@gavinandresen) contrib/seeds/makeseeds.py (@laanwj, @sipa, @gavinandresen) contrib/spendfrom/setup.py (@gavinandresen) contrib/spendfrom/spendfrom.py (@gavinandresen) contrib/testgen/base58.py (@laanwj) contrib/testgen/gen_base58_test_vectors.py (@laanwj) qa/rpc-tests/test_framework/blockstore.py (@MarcoFalke, @jonasschnelli, @casey, @mrbandrews)

  23. achow101 commented at 10:03 PM on September 11, 2016: member

    ACK (I thought my ACK was implied by my statement)

  24. MarcoFalke commented at 3:07 PM on September 19, 2016: member

    I think this is ready

    ACK dffe727

  25. laanwj merged this on Sep 19, 2016
  26. laanwj closed this on Sep 19, 2016
  27. laanwj referenced this in commit d8b4b631c5 on Sep 19, 2016
  28. luke-jr referenced this in commit a60d7cc97d on Sep 21, 2016
  29. codablock referenced this in commit d0fa50c1a7 on Sep 19, 2017
  30. codablock referenced this in commit d95a9728be on Jan 11, 2018
  31. lateminer referenced this in commit 6b6d0e9065 on Nov 9, 2018
  32. andvgal referenced this in commit 0e09591bba on Jan 6, 2019
  33. MarcoFalke locked this on Sep 8, 2021
Contributors
isle2983caseybrandondahlersipajonasschnellifanquakemrbandrewstheuniMarcoFalkebinflyingupcalebogdenachow101MitchellCashluke-jr
Labels
Docs
Linked (view graph)
#7300 [trivial] Add missing copyright headers#8700 [copyright] add MIT license headers to .sh scripts where missing#8701 [copyright] add MIT License copyright header to zmq_sub.py#8702 [copyright] add MIT License copyright header to remaining Python files
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 18:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me