fix op order to append first alert #8697

1. 
   rodasmith commented at 6:48 PM on September 10, 2016: contributor

   + has precedence over ?:, so strGUI += strGUI.empty() ? "" : uiAlertSerparator + _("Warning...") only appends "" if strGUI is empty. The ternary expression drops the warning for fLargeWorkForkFound or fLargeWorkInvalidChainFound if it is the first string to show.

   Fix by wrapping the ?: expression in parentheses, so even the first warning is appended to strGUI.

2. fix op order to append first alert 1d635ae61b
3. fanquake added the label GUI on Sep 11, 2016
4. 
   MarcoFalke commented at 9:32 AM on September 11, 2016: member

   Good catch. Even if it was correct as of now, 1d635ae61b26d1dd613c1cc1cac796627af2a31e is the easier to read version.

   utACK 1d635ae61b26d1dd613c1cc1cac796627af2a31e

5. MarcoFalke added the label Needs backport on Sep 11, 2016
6. MarcoFalke added this to the milestone 0.13.1 on Sep 11, 2016
7. 
   jonasschnelli commented at 9:36 AM on September 12, 2016: contributor

   Uh. Thanks. utACK 1d635ae61b26d1dd613c1cc1cac796627af2a31e

8. 
   btcdrak commented at 11:53 AM on September 12, 2016: contributor

   utACK 1d635ae

9. 
   fanquake commented at 11:57 AM on September 12, 2016: member

   utACK 1d635ae

10. 
    rubensayshi commented at 7:58 AM on September 13, 2016: contributor

    utACK https://github.com/bitcoin/bitcoin/commit/1d635ae61b26d1dd613c1cc1cac796627af2a31e

11. laanwj merged this on Sep 13, 2016
12. laanwj closed this on Sep 13, 2016

    ---

13. laanwj referenced this in commit 39ac1ec642 on Sep 13, 2016
14. MarcoFalke referenced this in commit 41fd852d3f on Sep 13, 2016
15. 
    laanwj commented at 2:13 PM on September 26, 2016: member

    This was backported as part of #8710, removing tag

16. laanwj removed the label Needs backport on Sep 26, 2016
17. codablock referenced this in commit acdcadaebc on Sep 19, 2017
18. codablock referenced this in commit 85ce0ef287 on Jan 11, 2018
19. lateminer referenced this in commit a02e75a50f on Oct 24, 2018
20. andvgal referenced this in commit 486168ddc9 on Jan 6, 2019
21. MarcoFalke locked this on Sep 8, 2021

Milestone
0.13.1