net: No longer send local address in addrMe #8740

1. 
   laanwj commented at 9:44 pm on September 15, 2016: member

   After #8594 the addrFrom sent by a node is not used anymore at all, so don’t bother sending it (it was already not used if it is an invalid address so this doesn’t disadvantage older versions either).

   Also mitigates the privacy issue in (#8616). It doesn’t completely solve the issue as GetLocalAddress is also called in AdvertiseLocal, but at least when advertising addresses it stands out less as our address.

2. net: No longer send local address in addrMe

   After #8594 the addrFrom sent by a node is not used anymore at all,
   so don't bother sending it.
   
   Also mitigates the privacy issue in (#8616). It doesn't completely solve
   the issue as GetLocalAddress is also called in AdvertiseLocal, but at
   least when advertising addresses it stands out less as *our* address.

   d9c99c3058
3. laanwj added the label P2P on Sep 15, 2016
4. sipa approved
5. 
   sipa commented at 9:58 pm on September 15, 2016: member

   utACK. The addrFrom value deserialized from the VERSION message (which this corresponds to) is unused.
6. dcousens approved
7. 
   dcousens commented at 1:41 am on September 16, 2016: contributor

   utACK
8. 
   paveljanik commented at 4:31 pm on September 17, 2016: contributor

   ACK https://github.com/bitcoin/bitcoin/pull/8740/commits/d9c99c3058c90f4f7075cf5c495b8dcd2e7519a7

   The new us (https://github.com/laanwj/bitcoin/blob/d9c99c3058c90f4f7075cf5c495b8dcd2e7519a7/src/net.cpp#L453) is [::]:0.

9. 
   gmaxwell commented at 9:50 pm on September 18, 2016: contributor

   ACK (perhaps backport too)
10. laanwj added the label Backport on Sep 19, 2016
11. laanwj merged this on Sep 19, 2016
12. laanwj added the label Needs backport on Sep 19, 2016
13. laanwj removed the label Backport on Sep 19, 2016
14. laanwj closed this on Sep 19, 2016

    ---

15. laanwj referenced this in commit 239e8ce958 on Sep 19, 2016
16. MarcoFalke added this to the milestone 0.13.1 on Sep 19, 2016
17. luke-jr referenced this in commit 42ea51a65f on Sep 21, 2016
18. 
    laanwj commented at 1:51 pm on September 26, 2016: member

    This is backported in #8772, removing tag
19. laanwj removed the label Needs backport on Sep 26, 2016
20. pyritepirate referenced this in commit 3a80e10e8c on Jan 14, 2019
21. MarcoFalke referenced this in commit c49971f3c9 on Apr 12, 2020
22. random-zebra referenced this in commit 777638e7bc on Aug 27, 2020
23. vijaydasmp referenced this in commit 491946679d on Aug 24, 2021
24. PastaPastaPasta referenced this in commit e60b249883 on Aug 30, 2021
25. MarcoFalke locked this on Sep 8, 2021

Contributors
laanwj sipa dcousens paveljanik gmaxwell

Labels
P2P

Milestone
0.13.1