Calling ThreadFlushWalletDB makes not much sense if an explicit flush is required. The function will return immediately because of the fOneThread (populated/thread started during AppInit).
Removing it for now.
[Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds #8765
pull jonasschnelli wants to merge 1 commits into bitcoin:master from jonasschnelli:2016/09/flush_wallet_dump changing 1 files +0 −2-
jonasschnelli commented at 2:21 PM on September 20, 2016: contributor
-
[Wallet] remove "unused" ThreadFlushWalletDB from removeprunedfunds c6f5ca822f
- jonasschnelli added the label Wallet on Sep 20, 2016
-
laanwj commented at 2:23 PM on September 20, 2016: member
Good catch. A shame we didn't catch this in the review. Calling into another thread's main function is 100% of times a mistake. utACK https://github.com/bitcoin/bitcoin/pull/8765/commits/c6f5ca822f1308983431bf1b3c91f8aaccff51a0
- laanwj approved
- paveljanik approved
-
paveljanik commented at 4:42 PM on September 20, 2016: contributor
- fanquake approved
-
fanquake commented at 12:39 AM on September 21, 2016: member
utACK c6f5ca8
- luke-jr approved
-
luke-jr commented at 6:13 AM on September 21, 2016: member
utACK
- laanwj merged this on Sep 21, 2016
- laanwj closed this on Sep 21, 2016
- laanwj referenced this in commit b4f53641a9 on Sep 21, 2016
-
luke-jr commented at 6:23 AM on September 27, 2016: member
Backport for 0.13.1?
- laanwj added the label Needs backport on Sep 27, 2016
- MarcoFalke added this to the milestone 0.13.1 on Sep 27, 2016
- MarcoFalke referenced this in commit 62886598db on Oct 3, 2016
-
- laanwj removed the label Needs backport on Oct 13, 2016
- laanwj removed this from the milestone 0.13.1 on Oct 13, 2016
- sickpig referenced this in commit 028ec007c5 on Feb 17, 2017
- codablock referenced this in commit 563b7e5110 on Sep 19, 2017
- codablock referenced this in commit e02b48cad0 on Jan 11, 2018
- andvgal referenced this in commit 32dcc5bbf6 on Jan 6, 2019
- MarcoFalke locked this on Sep 8, 2021
