[depends] Fix Qt compilation with Xcode 8 #8820

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:depends-qt-xcoderun changing 2 files +27 −1
  1. fanquake commented at 4:37 AM on September 27, 2016: member

    Compiling Qt with the depends system is currently broken on OSX with Xcode 8 upstream Qt bug (Xcode 8 is no longer in beta).

    This patches qtbase/configure and qtbse/mkspecs/features/mac/default_pre.prf to work around the issue.

    Up for discussion wether we patch this now, wait for a 5.6.2 release and move depends to it, or leave this broken until we move to 5.7 / 5.8 in future.

  2. [depends] Fix Qt compilation with Xcode 8 5776e8a596
  3. fanquake added the label MacOSX on Sep 27, 2016
  4. fanquake added the label Build system on Sep 27, 2016
  5. jonasschnelli commented at 6:19 AM on September 27, 2016: contributor

    Looks good. I think applying the patch on all platforms shouldn't hurt.

    I have never used the depends build system on OSX, but I'll give it try soon.

  6. jonasschnelli approved
  7. jonasschnelli commented at 1:05 PM on September 28, 2016: contributor

    utACK 5776e8a5965f1d614516dc89da5fedb324baf62a

  8. laanwj merged this on Sep 28, 2016
  9. laanwj closed this on Sep 28, 2016

  10. laanwj referenced this in commit dc641415e7 on Sep 28, 2016
  11. fanquake deleted the branch on Oct 1, 2016
  12. MarcoFalke commented at 5:21 PM on October 13, 2016: member

    Qt 5.6.2 has been released yesterday. So we could get rid of the patch by bumping from 5.6.1 to 5.6.2, if that makes sense.

  13. laanwj commented at 6:21 PM on October 13, 2016: member

    On master I'd rather make a major version bump, I remember there were some other reasons to go to 5.7. For 0.13.1 it could make sense, although we already have this patch, so it'd depend on what else is fixed there.

  14. MarcoFalke commented at 6:24 PM on October 13, 2016: member

    <strike>There should be no issue with 0.13, as the branch is on 5.5

    Oh, 0.13 is on 5.6.1 as well. Not sure what to do then. Qt 5.7 is tracked over there: #8237

  15. codablock referenced this in commit e514fce11d on Sep 19, 2017
  16. codablock referenced this in commit 3a503b99f2 on Jan 12, 2018
  17. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me