[qt] sync-overlay: Don't block during reindex #8821

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1609-qtSyncReindex changing 3 files +21 −14
  1. MarcoFalke commented at 7:44 AM on September 27, 2016: member

    As I understand this, the "fHeader-shortcut" in clientmodel will fire too much during reindex, thus making the gui freeze. The reason for this shurtcut is to make sure the gui always knows the height of the best header. Though, I think it is not required for the gui to have this knowledge (after all it is just a warning dialog) and an approximate display is just fine.

  2. [qt] sync-overlay: Don't block during reindex faa4de2a2a
  3. MarcoFalke added the label GUI on Sep 27, 2016
  4. jonasschnelli commented at 1:23 PM on September 28, 2016: contributor

    I think the constant upcounting "Number of blocks left" is confusing (even with the ~). I prefer to keep it "unknown" until we have synced the headers chain.

  5. [qt] sync-overlay: Don't show estimated number of headers left fa85e860a9
  6. MarcoFalke force-pushed on Sep 29, 2016
  7. MarcoFalke commented at 1:16 PM on September 29, 2016: member

    Done

  8. jonasschnelli commented at 9:46 AM on October 10, 2016: contributor

    Tested ACK fa85e860a9261e6c585ec40e67845fa93a20c6e7

  9. jonasschnelli merged this on Oct 10, 2016
  10. jonasschnelli closed this on Oct 10, 2016

  11. jonasschnelli referenced this in commit bf8e68aba6 on Oct 10, 2016
  12. MarcoFalke deleted the branch on Oct 10, 2016
  13. luke-jr referenced this in commit 5aa0558084 on Oct 20, 2016
  14. luke-jr referenced this in commit 71e2404501 on Oct 20, 2016
  15. codablock referenced this in commit 762474dee8 on Sep 7, 2017
  16. UdjinM6 referenced this in commit 9707ca5cea on Sep 9, 2017
  17. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me